configure preview deployments for Pull Requests

[k-yle]

Every PR now gets deployed to netlify, similar to how it works in openstreetmap/id-tagging-schema.

In this repo, we use the GitHub Deployments API instead of posting a PR comment, just to reduce noise and notifications. The link to the deployed version is still shown in the PR page:

Demo: PR #1 and PR #2 (from a fork). It won't work for this PR itself, it'll only work once this is merged

[tyrasd]

Thanks, this looks great with the gh deployments integration!

Other than the small question/suggestion below (and @hlfan's suggestion to keep the no-await-in-loop linter rule), it's looking really good. Feel free to swap over to the final deployment URL when you think it's ready to be merged. ☺️

[k-yle]

oh, it failed because the NETLIFY_* env variables aren't accessible, @tyrasd are these variables limited to the develop branch at the moment? I don't have access to the corresponding settings page to check

[tyrasd]

yeah, I just realized that I have set up the secrets as github "environments", which needs to be specified for the respective workflows, see 2e71cbe. It works now (example PR: #11334). 🙇

[tyrasd]

FYI: I just configured the API key for iD on the OSM sandbox / test instance https://api06.dev.openstreetmap.org/ to allow the use on https://pr-…--ideditor.netlify.app/ domains. Unfortunately, the OSM API does not allow to use wildcards in the landing URL for oauth2 applications, so I have manually whitelisted a whole bunch on domains (currently for pr ids 11388..11999), allowing to test also uploads from the PR preview instances of iD (after switching to the dev API connection). Feel free to ping me when additional subdomains are needed.