Skip to content

Conversation

@AbdulWahabMemon
Copy link
Contributor

@AbdulWahabMemon AbdulWahabMemon commented Aug 4, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1456

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1506 (faf28eb) into mwcore-dev (0ae3f3c) will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@               Coverage Diff                @@
##             mwcore-dev    #1506      +/-   ##
================================================
+ Coverage         63.56%   63.60%   +0.04%     
- Complexity          754      757       +3     
================================================
  Files               136      136              
  Lines              4836     4847      +11     
  Branches            771      773       +2     
================================================
+ Hits               3074     3083       +9     
- Misses             1313     1315       +2     
  Partials            449      449              
Flag Coverage Δ
engine 63.60% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 80.00% <83.33%> (ø)
...gister/fhircore/engine/domain/model/ProfileData.kt 98.36% <100.00%> (+0.02%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@AbdulWahabMemon AbdulWahabMemon changed the title 1456 set careplan id in questionnaire edit 1456 pass careplan to questionnaire Aug 5, 2022
@AbdulWahabMemon AbdulWahabMemon requested a review from LZRS August 5, 2022 08:09
@AbdulWahabMemon AbdulWahabMemon marked this pull request as ready for review August 5, 2022 08:28
@AbdulWahabMemon AbdulWahabMemon merged commit d564624 into mwcore-dev Aug 5, 2022
@AbdulWahabMemon AbdulWahabMemon deleted the 1456_set_careplan_id_in_questionnaire_edit branch August 5, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants