Skip to content

Conversation

@LZRS
Copy link
Contributor

@LZRS LZRS commented Aug 3, 2022

Fixes #1484

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1501 (a4467cb) into mwcore-dev (8c850f1) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@               Coverage Diff                @@
##             mwcore-dev    #1501      +/-   ##
================================================
+ Coverage         63.52%   63.55%   +0.02%     
- Complexity          754      755       +1     
================================================
  Files               136      136              
  Lines              4823     4829       +6     
  Branches            769      770       +1     
================================================
+ Hits               3064     3069       +5     
- Misses             1312     1313       +1     
  Partials            447      447              
Flag Coverage Δ
engine 63.55% <83.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 81.48% <75.00%> (-0.10%) ⬇️
...gister/fhircore/engine/domain/model/ProfileData.kt 98.36% <100.00%> (+0.02%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@LZRS LZRS force-pushed the 1484-pass-active-conditions branch from 3436f1e to a4467cb Compare August 3, 2022 13:55
@LZRS
Copy link
Contributor Author

LZRS commented Aug 5, 2022

Changes in this PR, have been merged through #1506 (review)

@LZRS LZRS closed this Aug 5, 2022
@ellykits ellykits deleted the 1484-pass-active-conditions branch May 26, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants