-
Notifications
You must be signed in to change notification settings - Fork 74
[release-4.18] OCPBUGS-73930: Add APIServer to HybridOverlay config #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18] OCPBUGS-73930: Add APIServer to HybridOverlay config #3700
Conversation
|
Skipping CI for Draft Pull Request. |
|
/jira-cherrypick OCPBUGS-68362 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira cherry-pick OCPBUGS-68362 |
|
@jrvaldes: Jira Issue OCPBUGS-68362 has been cloned as Jira Issue OCPBUGS-73930. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jrvaldes: This pull request references Jira Issue OCPBUGS-73930, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This commit ensures the hybridOverlay service receives explicitly the address of the API Server Endpoint along with the cacert to enable certificate rotation. The --bootstrap-kubeconfig flag should be enough but there is a bug in OVN-K HybridOverlay [1] where the apiserver and cacert are not extracted from the bootstrap information, hence introducing the --k8s-apiserver and --k8s-cacert flags as part of the command. [1] https://issues.redhat.com/browse/OCPBUGS-65856 (cherry picked from commit 6af0569)
|
Tests passed ci/prow/aws-e2e-operator |
4acb271 to
3cebdf1
Compare
|
pushed an update to please the linter |
|
/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-disconnected-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator |
|
@jrvaldes: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/aws-e2e-operator, ci/prow/azure-e2e-operator, ci/prow/gcp-e2e-operator, ci/prow/nutanix-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/azure-e2e-upgrade ci/prow/platform-none-vsphere-e2e-operator |
|
/override ci/prow/vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/azure-e2e-upgrade, ci/prow/platform-none-vsphere-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/vsphere-e2e-operator, ci/prow/vsphere-proxy-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/vsphere-disconnected-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/vsphere-disconnected-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
360e4bb
into
openshift:release-4.18
|
@jrvaldes: Jira Issue OCPBUGS-73930: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-73930 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
manual backport for