-
Notifications
You must be signed in to change notification settings - Fork 74
[release-4.19] OCPBUGS-68362: Add APIServer to HybridOverlay config #3646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.19] OCPBUGS-68362: Add APIServer to HybridOverlay config #3646
Conversation
This commit ensures the hybridOverlay service receives explicitly the address of the API Server Endpoint along with the cacert to enable certificate rotation. The --bootstrap-kubeconfig flag should be enough but there is a bug in OVN-K HybridOverlay [1] where the apiserver and cacert are not extracted from the bootstrap information, hence introducing the --k8s-apiserver and --k8s-cacert flags as part of the command. [1] https://issues.redhat.com/browse/OCPBUGS-65856
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-66266 has been cloned as Jira Issue OCPBUGS-68362. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-68362, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test aws-e2e-operator |
|
aws-e2e-operator failing due to AWS instance metadata issues routes opened by |
|
aws-e2e-operator failed at node deletion at cleanup, there is sufficient CI coverage for the changes introduced in this PR. |
|
/override ci/prow/aws-e2e-operator to move forward with the backport for QE testing |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/aws-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
712ac31
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-68362: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-68362 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@jrvaldes: #3646 failed to apply on top of branch "release-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.18 |
|
@jrvaldes: #3646 failed to apply on top of branch "release-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #3608
/assign jrvaldes