Skip to content

[test] Set replica count based on affinity#307

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:e2e-north-south-spread-pods
May 26, 2021
Merged

[test] Set replica count based on affinity#307
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:e2e-north-south-spread-pods

Conversation

@aravindhp
Copy link
Contributor

@aravindhp aravindhp commented Feb 15, 2021

createWindowsServerDeployment() is used to create the deployment for east-west and north-south networking tests. east-west tests require pods to be placed on particular nodes while this does not matter for
north-south networking tests. Moreover not spreading pods across nodes prevents us from testing scenarios like BZ 1905950.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2021
@aravindhp
Copy link
Contributor Author

aravindhp commented Feb 15, 2021

/hold
/approve cancel
/cc @openshift/openshift-team-windows-containers

@openshift-ci-robot openshift-ci-robot requested a review from a team February 15, 2021 20:12
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2021
@aravindhp
Copy link
Contributor Author

aravindhp commented Feb 15, 2021 •
edited
Loading

north-south networking tests failed on AWS and Azure so it is possible that BZ 1905950 is still in play. Interesting that it did not fail on vSphere.

@aravindhp
Copy link
Contributor Author

aravindhp commented Feb 15, 2021

/retest
/test vsphere-e2e-operator

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 8, 2021

/retest

To check if there is any change in behavior

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

/retest

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

/test vsphere-e2e-operator

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

/test azure-e2e-operator

The test dying in a strange spot. Retesting to see if it is consistent behavior.

@aravindhp aravindhp mentioned this pull request Mar 12, 2021
Merged
@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

/test azure-e2e-operator

Seeing a strange 2 hr lapse in setting up the SSH connection:

2021-03-12T08:06:19.666Z	DEBUG	VM e2e-wmcow-5vcsx	initializing SSH connection	{"user": "capi"}
2021-03-12T08:08:32.005Z	DEBUG	VM e2e-wmcow-5vcsx	SSH dial	{"IP Address": "10.0.32.8", "error": "dial tcp 10.0.32.8:22: connect: connection timed out"}

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

I misread a 2 minute lapse for a 2 hour lapse 🤦🏾

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 12, 2021

Looking at the timestamps of WMCO and machine-api-controller there does not seem to be any time discrepancy. It is plausible that the north-south networking test was retrying when the 2 hour limit was hit and hence the lack of output.

@aravindhp
Copy link
Contributor Author

aravindhp commented Mar 15, 2021

/retest

@aravindhp aravindhp force-pushed the e2e-north-south-spread-pods branch from 80e4bbd to fbd7c98 Compare March 15, 2021 22:36
@aravindhp
[test] Set replica count based on affinity
80f87db 
createWindowsServerDeployment() is used to create the deployment for
east-west and north-south networking tests. east-west tests require pods
to be placed on particular nodes while this does not matter for
north-south networking tests. Moreover not spreading pods across nodes
prevents us from testing scenarios like
https://bugzilla.redhat.com/show_bug.cgi?id=1905950.
@aravindhp aravindhp force-pushed the e2e-north-south-spread-pods branch from fbd7c98 to 80f87db Compare March 15, 2021 22:38
@aravindhp
Copy link
Contributor Author

aravindhp commented Apr 10, 2021

/retest

1 similar comment
@aravindhp
Copy link
Contributor Author

aravindhp commented May 11, 2021

/retest

@aravindhp aravindhp mentioned this pull request May 24, 2021
Merged
@aravindhp
Copy link
Contributor Author

aravindhp commented May 25, 2021

Now that #457 has merged and BZ1905950 has been fixed.

/test azure-e2e-operator
/test aws-e2e-operator

@aravindhp
Copy link
Contributor Author

aravindhp commented May 25, 2021

/test azure-e2e-operator

@aravindhp
Copy link
Contributor Author

aravindhp commented May 25, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2021
jrvaldes
jrvaldes approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 73518a6 into openshift:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sebsoto sebsoto sebsoto approved these changes

@jrvaldes jrvaldes jrvaldes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jrvaldes jrvaldes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aravindhp @openshift-ci-robot @sebsoto @jrvaldes @openshift-merge-robot