Skip to content

BZ#1937930 Update Windows server support#30388

Merged
codyhoag merged 1 commit intoopenshift:masterfrom
codyhoag:winc-vsphere-clarifications
Mar 18, 2021
Merged

BZ#1937930 Update Windows server support#30388
codyhoag merged 1 commit intoopenshift:masterfrom
codyhoag:winc-vsphere-clarifications

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Mar 12, 2021

https://bugzilla.redhat.com/show_bug.cgi?id=1937930

Caused by Engineering BZ https://bugzilla.redhat.com/show_bug.cgi?id=1905950. Until this Engineering BZ is resolved, WINC will require these support updates.

The following three articles were updated (previews):

@codyhoag codyhoag added this to the Next Release milestone Mar 12, 2021
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021
@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for osdocs ready!

Built with commit 4a2a4c3

https://deploy-preview-30388--osdocs.netlify.app

@Anandnatraj
Copy link

LGTM

Copy link

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around, @codyhoag

@Anandnatraj
Copy link

LGTM

@codyhoag codyhoag changed the title Update Windows server support Bug 1937930: Update Windows server support Mar 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 12, 2021
@openshift-ci-robot
Copy link

@codyhoag: This pull request references Bugzilla bug 1937930, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1937930: Update Windows server support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2021
@aravindhp
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 12, 2021
@openshift-ci-robot
Copy link

@aravindhp: This pull request references Bugzilla bug 1937930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xtian@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Anandnatraj
Copy link

There is currently an issue in Windows Server 2019 versions released after version 10.0.17763.1457 where Windows workloads behind a load balancer are unreachable for clusters installed on AWS. The Windows Server 2019 version 10.0.17763.1457 and earlier are recommended to work around this issue; however, these earlier images are no longer available. This image version unavailability prevents the ability to run Windows workloads behind a load balancer on clusters installed on AWS at this time. See this Microsoft Windows Containers issue for more details.

I think the statement above should read: where Windows workloads behind a load balancer are unreachable for clusters installed on AWS and Azure. We need Windows Server 2019 version 10.0.17763.1457 on both AWS snd Azure

@openshift-ci-robot
Copy link

@codyhoag: This pull request references Bugzilla bug 1937930, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sgaoshang

Details

In response to this:

Bug 1937930: Update Windows server support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag force-pushed the winc-vsphere-clarifications branch from 177548e to 021325a Compare March 12, 2021 18:15
@codyhoag
Copy link
Contributor Author

@sgaoshang PTAL

@codyhoag codyhoag changed the title Bug 1937930: Update Windows server support BZ#1937930 Update Windows server support Mar 12, 2021
@codyhoag codyhoag force-pushed the winc-vsphere-clarifications branch from bbce0a7 to c9ceb18 Compare March 12, 2021 18:49
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 12, 2021
@openshift-ci-robot
Copy link

@codyhoag: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

BZ#1937930 Update Windows server support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2021
@codyhoag codyhoag force-pushed the winc-vsphere-clarifications branch from c9ceb18 to a57cf26 Compare March 12, 2021 18:57
@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2021
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor style nits but otherwise this LGTM!

@bobfuru bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2021
@codyhoag codyhoag force-pushed the winc-vsphere-clarifications branch from a57cf26 to 4a2a4c3 Compare March 12, 2021 21:04
@sgaoshang
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@codyhoag codyhoag merged commit 155e0c6 into openshift:master Mar 18, 2021
@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.8

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@codyhoag: new pull request created: #30647

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: new pull request created: #30648

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants