[release-4.13] WINC-1014: Enable vSphere in-tree storage by sebsoto · Pull Request #1547 · openshift/windows-machine-config-operator

sebsoto · 2023-04-10T17:14:56Z

Enables the use of in-tree storage for Windows nodes on vSphere.

Includes:

A kubelet update to capture OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514, which allows the kubelet feature vSphereCSIMigration to be disabled.
Changes to WMCO to disable the feature flag on Windows nodes, allowing the use of in-tree storage.
e2e testing, cherry-picked from release-4.12

sebsoto · 2023-04-10T17:15:06Z

/approve cancel

openshift-ci · 2023-04-10T17:15:27Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[nodeconfig] Disable vSphere CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-10T17:15:30Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sebsoto · 2023-04-10T17:18:35Z

/test vsphere-e2e-operator

openshift-ci · 2023-04-10T17:18:51Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13][nodeconfig] Disable vSphere CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-10T17:18:56Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] Disable vSphere CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-13T16:49:06Z

@sebsoto: This pull request references WINC-1014 which is a valid jira issue.

Details

In response to this:

Enables the use of in-tree storage for vSphere.
This feature flag was locked to true until recently upstream, and is still in the process of making its way into openshift/kubernetes. Because it is not yet downstreamed, this cannot be tested. When it is downstreamed, fc6517f, can be cherry-picked in order to test this change.

See openshift/kubernetes#1514 for more context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-13T16:49:12Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] WINC-1014: Disable vSphere CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sebsoto · 2023-04-21T13:33:21Z

/test vsphere-e2e-operator

sebsoto · 2023-04-22T01:07:48Z

/test vsphere-e2e-operator

Update to openshift/kubernetes@b404935 This commit was generated using hack/update_submodules.sh

This commit was generated using hack/update_submodules.sh

openshift-ci · 2023-04-24T19:02:52Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] WINC-1014: Enable vSphere in-tree storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-24T19:03:29Z

@sebsoto: This pull request references WINC-1014 which is a valid jira issue.

Details

In response to this:

Enables the use of in-tree storage for vSphere.
See openshift/kubernetes#1514 for more context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-24T19:03:31Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] WINC-1014: Enable vSphere in-tree storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-24T19:03:45Z

@sebsoto: This pull request references WINC-1014 which is a valid jira issue.

Details

In response to this:

Enables the use of in-tree storage for Windows nodes on vSphere.
See openshift/kubernetes#1514 for more context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-24T19:03:47Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] WINC-1014: Enable vSphere in-tree storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-24T19:08:03Z

@sebsoto: This pull request references WINC-1014 which is a valid jira issue.

Details

In response to this:

Enables the use of in-tree storage for Windows nodes on vSphere.

Includes:

A kubelet update to capture OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514, which allows the kubelet feature vSphereCSIMigration to be disabled.

Changes to WMCO to disable the feature flag on Windows nodes, allowing the use of in-tree storage.

e2e testing, cherry-picked from release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-24T19:08:12Z

@sebsoto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] WINC-1014: Enable vSphere in-tree storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sebsoto · 2023-04-24T19:08:48Z

/test e2e-vsphere-operator

sebsoto · 2023-04-24T19:08:58Z

/test vsphere-e2e-operator

openshift-ci · 2023-04-24T19:09:15Z

@sebsoto: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test aws-e2e-operator
/test aws-e2e-upgrade
/test azure-e2e-ccm-install
/test azure-e2e-operator
/test build
/test ci-index
/test gcp-e2e-operator
/test images
/test lint
/test platform-none-vsphere-e2e-operator
/test unit
/test vsphere-e2e-operator
/test wicd-unit-vsphere

Use /test all to run all jobs.

Details

In response to this:

/test e2e-vsphere-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp

Thanks for working on this, @sebsoto. Please address my comments.

pkg/ignition/ignition.go

aravindhp · 2023-04-24T19:40:18Z

test/e2e/providers/vsphere/vsphere.go

+			GenerateName: "e2e-",
+		},
+		Spec: core.PersistentVolumeClaimSpec{
+			AccessModes: []core.PersistentVolumeAccessMode{core.ReadWriteOnce},


Shouldn't we be testing ReadWriteMany as we have had requests for that?

ReadWriteMany requires the vSphere env to support it. VMC does not support it.
Potentially we could try to determine if the workload is running in an environment that does support it, and use it in that case. I'm not sure how to do that, and would prefer to not have to add that extra work into this PR which is a release blocker.

I am fine not doing that in this PR but we need to track getting this to work in VMC. Maybe a SPLAT ticket? We don't want to wait for a customer issue to be opened to enable this in VMC.

test/e2e/providers/vsphere/vsphere.go

saifshaikh48

/lgtm

Nice work, the changes and reasoning are clear

aravindhp · 2023-04-25T17:21:58Z

test/e2e/providers/vsphere/vsphere.go

+			GenerateName: "e2e-",
+		},
+		Spec: core.PersistentVolumeClaimSpec{
+			AccessModes: []core.PersistentVolumeAccessMode{core.ReadWriteOnce},


I am fine not doing that in this PR but we need to track getting this to work in VMC. Maybe a SPLAT ticket? We don't want to wait for a customer issue to be opened to enable this in VMC.

test/e2e/providers/vsphere/vsphere.go

openshift-ci · 2023-04-25T17:25:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [aravindhp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Enables the use of in-tree storage for vSphere by setting the vSphereCSIMigration kubelet feature flag to false, and forcing the use of the `vSphere` cloud provider in kubelet, allowing in-tree volumes to be successfully mounted.

Adds creation of a PVC by using the in-tree storage driver to the vSphere provider, and enables testing of storage. (cherry picked from commit fc6517f)

Minor code tweaks for clarity.

sebsoto · 2023-04-25T22:19:19Z

/test wicd-unit-vsphere

openshift-ci · 2023-04-25T22:55:23Z

@sebsoto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

saifshaikh48

/lgtm

alinaryan · 2023-04-26T00:02:42Z

LGTM

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023

sebsoto changed the title ~~[nodeconfig] Disable vSphere CSI migration~~ [release-4.13][nodeconfig] Disable vSphere CSI migration Apr 10, 2023

sebsoto changed the title ~~[release-4.13][nodeconfig] Disable vSphere CSI migration~~ [release-4.13] Disable vSphere CSI migration Apr 10, 2023

sebsoto changed the title ~~[release-4.13] Disable vSphere CSI migration~~ [release-4.13] WINC-1014: Disable vSphere CSI migration Apr 13, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2023

sebsoto force-pushed the vsphereCSIFlag branch from a36fb1d to 0b3edee Compare April 21, 2023 13:32

sebsoto added 2 commits April 22, 2023 19:46

[submodule][kubelet] Update to b4049358407

6ae202f

Update to openshift/kubernetes@b404935 This commit was generated using hack/update_submodules.sh

[build] Update kubelet version to v1.26.3+b404935

2113f56

This commit was generated using hack/update_submodules.sh

sebsoto force-pushed the vsphereCSIFlag branch 2 times, most recently from 9686d3a to 0e585d3 Compare April 24, 2023 19:01

sebsoto changed the title ~~[release-4.13] WINC-1014: Disable vSphere CSI migration~~ [release-4.13] WINC-1014: Enable vSphere in-tree storage Apr 24, 2023

aravindhp suggested changes Apr 24, 2023

View reviewed changes

saifshaikh48 reviewed Apr 25, 2023

View reviewed changes

openshift-ci bot assigned saifshaikh48 Apr 25, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023

aravindhp approved these changes Apr 25, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023

sebsoto marked this pull request as ready for review April 25, 2023 17:32

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023

openshift-ci bot requested review from aravindhp and mansikulkarni96 April 25, 2023 17:33

sebsoto added 3 commits April 25, 2023 14:06

[nodeconfig] Disable vSphere CSI migration

f6e8881

Enables the use of in-tree storage for vSphere by setting the vSphereCSIMigration kubelet feature flag to false, and forcing the use of the `vSphere` cloud provider in kubelet, allowing in-tree volumes to be successfully mounted.

[test] Add in-tree storage testing for vSphere

a5271c6

Adds creation of a PVC by using the in-tree storage driver to the vSphere provider, and enables testing of storage. (cherry picked from commit fc6517f)

[test] vSphere provider storage improvements

5f957c4

Minor code tweaks for clarity.

sebsoto force-pushed the vsphereCSIFlag branch from 6dec21c to 5f957c4 Compare April 25, 2023 18:06

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023

saifshaikh48 reviewed Apr 25, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023

openshift-merge-robot merged commit fbe9551 into openshift:release-4.13 Apr 25, 2023

Conversation

sebsoto commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebsoto commented Apr 10, 2023

Uh oh!

openshift-ci bot commented Apr 10, 2023

Uh oh!

openshift-ci bot commented Apr 10, 2023

Uh oh!

sebsoto commented Apr 10, 2023

Uh oh!

openshift-ci bot commented Apr 10, 2023

Uh oh!

openshift-ci bot commented Apr 10, 2023

Uh oh!

openshift-ci-robot commented Apr 13, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebsoto commented Apr 21, 2023

Uh oh!

sebsoto commented Apr 22, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebsoto commented Apr 24, 2023

Uh oh!

sebsoto commented Apr 24, 2023

Uh oh!

openshift-ci bot commented Apr 24, 2023

Uh oh!

aravindhp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aravindhp Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

sebsoto Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

aravindhp Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saifshaikh48 left a comment

Choose a reason for hiding this comment

Uh oh!

aravindhp Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented Apr 25, 2023

Uh oh!

sebsoto commented Apr 25, 2023

Uh oh!

sebsoto commented Apr 10, 2023 •

edited

Loading

openshift-ci-robot commented Apr 13, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 13, 2023 •

edited

Loading

openshift-ci bot commented Apr 24, 2023 •

edited

Loading

openshift-ci-robot commented Apr 24, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 24, 2023 •

edited

Loading

openshift-ci-robot commented Apr 24, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 24, 2023 •

edited

Loading

openshift-ci-robot commented Apr 24, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 24, 2023 •

edited

Loading