Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-41131: Enable FIPs 4.17 #117

Merged
merged 3 commits into from
Sep 9, 2024
Merged

OCPBUGS-41131: Enable FIPs 4.17 #117

merged 3 commits into from
Sep 9, 2024

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Sep 5, 2024

No description provided.

adrianchiris and others added 3 commits September 4, 2024 22:53
@adrianchiris @vrindle
cleanup makefile
bf23811 
- cleanup makefile
- update workflows
- remove deprecated linters from .golangci.yml

Signed-off-by: adrianc <[email protected]>
@bn222 @vrindle
Allow to override go tags in build
1f5989b 
Signed-off-by: Balazs Nemeth <[email protected]>
@vrindle
Ensure FIPS compliance when building device plugin
85bbb5f
@vrindle vrindle changed the title Pull request 4.17 Enable FIPs 4.17 Sep 5, 2024
@vrindle vrindle changed the title Enable FIPs 4.17 OCPBUGS-41131: Enable FIPs 4.17 Sep 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-41133 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-41133 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-41133 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-41133 to target a version in 4.18.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira-refresh

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-41133 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • expected dependent Jira Issue OCPBUGS-41133 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

@vrindle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor

bn222 commented Sep 5, 2024

/lgtm
/backport-risk-assessed

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2024
@bn222
Copy link
Contributor

bn222 commented Sep 5, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • expected the bug to target only the "4.17.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Sep 5, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-41133 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-41133 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhaozhanqi
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Sep 6, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-41133 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-41133 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhaozhanqi
Copy link

tested looks good

[root@openshift-qe-024 ~]# fips-mode-setup --check
FIPS mode is enabled.

oc get pod -n openshift-sriov-network-operator -o wide -l app=sriov-device-plugin
NAME                        READY   STATUS    RESTARTS   AGE     IP               NODE                                       NOMINATED NODE   READINESS GATES
sriov-device-plugin-vlblx   1/1     Running   0          4m58s   192.168.111.31   openshift-qe-024.lab.eng.rdu2.redhat.com   <none>           <none>

@bn222
Copy link
Contributor

bn222 commented Sep 9, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6e5877f into openshift:release-4.17 Sep 9, 2024
5 checks passed
@openshift-ci-robot
Copy link
Contributor

@vrindle: Jira Issue OCPBUGS-41131: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41131 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-device-plugin
This PR has been included in build sriov-network-device-plugin-container-v4.17.0-202409091636.p0.g6e5877f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Billy99 Billy99 Awaiting requested review from Billy99

@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@bn222 bn222

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@evgenLevin evgenLevin

@qiowang721 qiowang721

@ajaggapa ajaggapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.