Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-41133: Enable Fips #110

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Sep 5, 2024

No description provided.

adrianchiris and others added 3 commits September 4, 2024 22:53
- cleanup makefile
- update workflows
- remove deprecated linters from .golangci.yml

Signed-off-by: adrianc <[email protected]>
@vrindle vrindle changed the title Fips 4.17 Enable Fips Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

@vrindle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrindle vrindle changed the title Enable Fips OCPBUGS-41131 Enable Fips Sep 5, 2024
@vrindle vrindle changed the title OCPBUGS-41131 Enable Fips OCPBUGS-41131: Enable Fips Sep 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41131, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle vrindle changed the title OCPBUGS-41131: Enable Fips OCPBUGS-41133: Enable Fips Sep 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-41133, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bn222
Copy link
Contributor

bn222 commented Sep 5, 2024

/lgtm
/backport-risk-assessed

@bn222
Copy link
Contributor

bn222 commented Sep 5, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 702698d into openshift:master Sep 5, 2024
5 checks passed
@openshift-ci-robot
Copy link
Contributor

@vrindle: Jira Issue OCPBUGS-41133: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41133 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-device-plugin
This PR has been included in build sriov-network-device-plugin-container-v4.18.0-202409051704.p0.g702698d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants