Bug 1794029: [4.2] Use k8s.io/client-go fork with informer fix, run update-deps #95
Conversation
We were requesting api/library-go/client-go master instead of release-4.2. Also lock down the versions of some other deps that we don't want to gratuitously update.
|
@danwinship: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/test all |
1 similar comment
|
/test all |
danwinship
force-pushed
the
fork-k8s-client-go-4.2
branch
from
d4b6f1f to
6d1ccb4
Compare
danwinship
changed the title
|
@danwinship: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
danwinship
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@danwinship: This pull request references Bugzilla bug 1794029, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@danwinship: This pull request references Bugzilla bug 1794029, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@danwinship: This pull request references Bugzilla bug 1794029, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There are a lot of differences between the original and this backport. However, I believe this to be due to the amount of change and enhancements that have occurred between 4.2 and master. |
ashcrow
added
the
cherry-pick-approved
|
@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1794029 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's not 4.2 vs master, it's just that we previously had basically 4.2.0 (or maybe even 4.2 alpha or something), and now we have something 4.2.z-ish with various bugfixes. |
5 participants
4.2 version of #93. Also includes belated glide.yaml fixup for 4.2 deps...