Bug 1812063: UPSTREAM 83911: Fix DeltaFIFO Replace method

[abhat]

Backport #60

[openshift-ci-robot]

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM 83911: Fix DeltaFIFO Replace method

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

#95 is supposed to fix shared informers in release-4.2.

It seems that kubernetes/kubernetes#83911 was not backported to kube 1.16 and 1.14. Are you sure that this commit is actually necessary or is it just something that we had randomly tried when we were trying to fix the informer problems?

[knobunc]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knobunc]

/bugzilla refresh

[openshift-ci-robot]

@abhat: An error was encountered searching for bug 1812063 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1812063?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1812063: UPSTREAM 83911: Fix DeltaFIFO Replace method

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@knobunc: This pull request references Bugzilla bug 1812063, which is invalid:

• expected dependent Bugzilla bug 1747532 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (CURRENTRELEASE) instead
• expected dependent Bugzilla bug 1747532 to target the "4.3.z" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knobunc]

@abhat - Sorry, this seems to have been fixed in 4.2.19 per https://bugzilla.redhat.com/show_bug.cgi?id=1747532#c14 can you confirm?

[abhat]

@danwinship you are right, this is the backport for the upstream k/k PR: kubernetes/kubernetes#83911. I think this combined with the informer changes that @squeed made in #79 should make sure we are covered. The fixes in #79 are already backported via: #90.

[abhat]

As per @danwinship this backport is not releveant since k/k didn't seem to have the backport into 1.14 either. The informer fix in #95 should be sufficient to address the problem.