NetworkPolicy ipblock except, port ranges#374
Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom Dec 9, 2021
Merged
NetworkPolicy ipblock except, port ranges#374openshift-merge-robot merged 4 commits intoopenshift:masterfrom
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
danwinship
force-pushed
the
networkpolicy-ranges
branch
from
ef9fd99 to
299b488
Compare
Contributor
Author
|
/retest |
danwinship
force-pushed
the
networkpolicy-ranges
branch
from
299b488 to
b17e0ec
Compare
This was referenced Nov 29, 2021
Contributor
Author
|
/uncc squeed |
openshift-ci
bot
requested review from
JacobTanenbaum
and removed request for
squeed
And ignore the policy entirely if it's too pathological.
There's no point in allowing an IPv6 IPBlock in openshift-sdn, but if someone does it, make sure we don't do anything weird.
danwinship
force-pushed
the
networkpolicy-ranges
branch
from
b17e0ec to
c680692
Compare
danwinship
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP because this builds on top of #372 and needs to wait for that to merge first.)This finishes up NetworkPolicy feature parity with ovn-kubernetes by implementing ipBlock except rules and port ranges, allowing us to simplify the docs by getting rid of all sdn-vs-ovn notes in the NetworkPolicy docs.
The OpenFlow that this code generates from ipblocks with exceptions is equivalent to what ovn-kubernetes generates.
This also addresses SDN-1960 by adding warning events when a NetworkPolicy generates a pathological number of OpenFlow rules (which seemed like a good thing to implement along with this, since the new code tends to generate lots of flows...)