Skip to content

Comments

WIP Un-skip egress/ipBlock tests on openshift-sdn#26647

Closed
danwinship wants to merge 2 commits intoopenshift:masterfrom
danwinship:sdn-egress-ipblock
Closed

WIP Un-skip egress/ipBlock tests on openshift-sdn#26647
danwinship wants to merge 2 commits intoopenshift:masterfrom
danwinship:sdn-egress-ipblock

Conversation

@danwinship
Copy link
Contributor

@danwinship danwinship commented Nov 29, 2021

Unskip tests for features that were implemented in 4.10.
depends on openshift/kubernetes#1075

(Also not actually merged in openshift-sdn yet (openshift/sdn#374); I'm using this to do a cluster-bot test run.)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship
To complete the pull request process, please assign eparis after the PR has been reviewed.
You can assign the PR to them by writing /assign @eparis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 29, 2021
@JacobTanenbaum
Copy link
Contributor

/retest

@danwinship
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@danwinship: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-cgroupsv2 f407212 link false /test e2e-aws-cgroupsv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor Author

/test e2e-gcp

1 similar comment
@JacobTanenbaum
Copy link
Contributor

/test e2e-gcp

JacobTanenbaum added a commit to JacobTanenbaum/sdn that referenced this pull request Dec 21, 2021
attempts to add NetworkPolicy Egress tests in origin PR
openshift/origin#26647 are flaky because of
assumptions made about when it is safe to unisolate pods new pods that
existing networkPolicies apply to

Becuase the syncFlows is rate limited it is not safe to assume that
all flows are synced when returning from np.refreshPodNetworkPolicies().
This PR changes how the flows that restrict new pods are removed by
removing the isolating flows as part of syncFlows if a recalulation is
required.
JacobTanenbaum added a commit to JacobTanenbaum/sdn that referenced this pull request Dec 21, 2021
attempts to add NetworkPolicy Egress tests in origin PR
openshift/origin#26647 are flaky because of
assumptions made about when it is safe to unisolate pods new pods that
existing networkPolicies apply to

Becuase the syncFlows is rate limited it is not safe to assume that
all flows are synced when returning from np.refreshPodNetworkPolicies().
This PR changes how the flows that restrict new pods are removed by
removing the isolating flows as part of syncFlows if a recalulation is
required.
JacobTanenbaum added a commit to JacobTanenbaum/sdn that referenced this pull request Dec 22, 2021
attempts to add NetworkPolicy Egress tests in origin PR
openshift/origin#26647 are flaky because of
assumptions made about when it is safe to unisolate pods new pods that
existing networkPolicies apply to

Becuase the syncFlows is rate limited it is not safe to assume that
all flows are synced when returning from np.refreshPodNetworkPolicies().
This PR changes how the flows that restrict new pods are removed by
removing the isolating flows as part of syncFlows if a recalulation is
required.
JacobTanenbaum added a commit to JacobTanenbaum/sdn that referenced this pull request Dec 22, 2021
attempts to add NetworkPolicy Egress tests in origin PR
openshift/origin#26647 are flaky because of
assumptions made about when it is safe to unisolate pods new pods that
existing networkPolicies apply to

Becuase the syncFlows is rate limited it is not safe to assume that
all flows are synced when returning from np.refreshPodNetworkPolicies().
This PR changes how the flows that restrict new pods are removed by
removing the isolating flows as part of syncFlows if a recalulation is
required.
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@danwinship: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@danwinship
Copy link
Contributor Author

/close
there's another version of this somewhere now

@danwinship danwinship closed this Mar 15, 2022
@danwinship danwinship deleted the sdn-egress-ipblock branch March 15, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants