WIP Un-skip egress/ipBlock tests on openshift-sdn#26647
WIP Un-skip egress/ipBlock tests on openshift-sdn#26647danwinship wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1bff2d8 to
f407212
Compare
|
/retest |
|
/test e2e-gcp |
|
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-gcp |
1 similar comment
|
/test e2e-gcp |
attempts to add NetworkPolicy Egress tests in origin PR openshift/origin#26647 are flaky because of assumptions made about when it is safe to unisolate pods new pods that existing networkPolicies apply to Becuase the syncFlows is rate limited it is not safe to assume that all flows are synced when returning from np.refreshPodNetworkPolicies(). This PR changes how the flows that restrict new pods are removed by removing the isolating flows as part of syncFlows if a recalulation is required.
attempts to add NetworkPolicy Egress tests in origin PR openshift/origin#26647 are flaky because of assumptions made about when it is safe to unisolate pods new pods that existing networkPolicies apply to Becuase the syncFlows is rate limited it is not safe to assume that all flows are synced when returning from np.refreshPodNetworkPolicies(). This PR changes how the flows that restrict new pods are removed by removing the isolating flows as part of syncFlows if a recalulation is required.
attempts to add NetworkPolicy Egress tests in origin PR openshift/origin#26647 are flaky because of assumptions made about when it is safe to unisolate pods new pods that existing networkPolicies apply to Becuase the syncFlows is rate limited it is not safe to assume that all flows are synced when returning from np.refreshPodNetworkPolicies(). This PR changes how the flows that restrict new pods are removed by removing the isolating flows as part of syncFlows if a recalulation is required.
attempts to add NetworkPolicy Egress tests in origin PR openshift/origin#26647 are flaky because of assumptions made about when it is safe to unisolate pods new pods that existing networkPolicies apply to Becuase the syncFlows is rate limited it is not safe to assume that all flows are synced when returning from np.refreshPodNetworkPolicies(). This PR changes how the flows that restrict new pods are removed by removing the isolating flows as part of syncFlows if a recalulation is required.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
@danwinship: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
Unskip tests for features that were implemented in 4.10.
depends on openshift/kubernetes#1075
(Also not actually merged in openshift-sdn yet (openshift/sdn#374); I'm using this to do a cluster-bot test run.)