Skip to content

Bug 1906844: Handle unsupported EndpointSlice and EndpointSliceProxying feature gates#230

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
abhat:sdn_featuregates
Dec 15, 2020
Merged

Bug 1906844: Handle unsupported EndpointSlice and EndpointSliceProxying feature gates#230
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
abhat:sdn_featuregates

Conversation

@abhat
Copy link
Contributor

@abhat abhat commented Dec 7, 2020 •
edited
Loading

This PR reverts commit 12b21f8.

It also validates that unsupported feature gates are not accidentally enabled by the daemonset/deployment that launches
openshift-sdn.

This is gated by the CNO PR: openshift/cluster-network-operator#905 landing first.

@abhat
Copy link
Contributor Author

abhat commented Dec 7, 2020

/assign @danwinship

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@danwinship
Copy link
Contributor

danwinship commented Dec 8, 2020

/lgtm
/hold
though I kind of feel like maybe it should check the gate and error out if you somehow managed to start it with the gate enabled

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 8, 2020
@abhat
Copy link
Contributor Author

abhat commented Dec 8, 2020

do we really think that's possible given that we have validation now to make sure that feature-gates can't be over-ridden by user-config? or are we just trying to be defensive about it?

@danwinship
Copy link
Contributor

danwinship commented Dec 9, 2020

Just being defensive. In theory someone could launch openshift-sdn via a non-CNO-managed DaemonSet

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@abhat abhat changed the title Revert "Forcibly turn off EndpointSlice feature gate" Handle unsupported EndpointSlice and EndpointSliceProxying feature gates Dec 9, 2020
danwinship
danwinship reviewed Dec 10, 2020
View reviewed changes
@abhat abhat changed the title Handle unsupported EndpointSlice and EndpointSliceProxying feature gates Bug 1906844: Handle unsupported EndpointSlice and EndpointSliceProxying feature gates Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2020

@abhat: This pull request references Bugzilla bug 1906844, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1906844: Handle unsupported EndpointSlice and EndpointSliceProxying feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 11, 2020
Merged
@abhat
Validate unsupported feature gates are not accidentally enabled
deffcd6 
This commit checks to ensure that the unsupported EndpointSlice
and EndpointSliceProxying feature gates are disabled. If somehow,
the user runs a daemonset that enables these feature gates, the proxy
setup will error out.

Signed-off-by: Aniket Bhat <anbhat@redhat.com>
@abhat
Copy link
Contributor Author

abhat commented Dec 14, 2020

/test e2e-aws
/test e2e-aws-upgrade
/test e2e-gcp

@danwinship
Copy link
Contributor

danwinship commented Dec 14, 2020

/lgtm
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9b44e03 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2020

@abhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1906844 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1906844: Handle unsupported EndpointSlice and EndpointSliceProxying feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squeed squeed Awaiting requested review from squeed

1 more reviewer

@danwinship danwinship danwinship left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danwinship danwinship

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhat @danwinship @openshift-ci-robot @openshift-bot @openshift-merge-robot