Skip to content

Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4.#905

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
abhat:sdn_featuregates
Dec 11, 2020
Merged

Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4.#905
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
abhat:sdn_featuregates

Conversation

@abhat
Copy link
Contributor

@abhat abhat commented Dec 7, 2020

This PR adds two commits:

  • Bump k8s version in CNO to 1.19.4
  • Disable the kubeproxy configuration for EndpointSlice and EndpointSliceProxying feature gates.

This obviates the need for: openshift/sdn@12b21f8

@abhat
Copy link
Contributor Author

abhat commented Dec 7, 2020

/assign @danwinship.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@abhat
Copy link
Contributor Author

abhat commented Dec 9, 2020

/test e2e-aws-sdn-multi

1 similar comment
@abhat
Copy link
Contributor Author

abhat commented Dec 9, 2020

/test e2e-aws-sdn-multi

@abhat
Copy link
Contributor Author

abhat commented Dec 9, 2020

/test e2e-aws-ovn-windows

abhat added 2 commits December 9, 2020 16:20
This commit disables the endpoint slice and endpointslice proxying
feature gates for kube-proxy configuration for openshift-sdn.
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhat
Copy link
Contributor Author

abhat commented Dec 10, 2020

/test e2e-aws-sdn-multi

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

@abhat looks like they turned on "you need a bz" checking

/override ci/prow/e2e-ovn-ipsec-step-registry
/override ci/prow/e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-openstack-ovn, ci/prow/e2e-ovn-ipsec-step-registry

Details

In response to this:

@abhat looks like they turned on "you need a bz" checking

/override ci/prow/e2e-ovn-ipsec-step-registry
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat abhat changed the title Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4. Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4. Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1906844, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Dec 11, 2020

/test e2e-aws-ovn-windows

@abhat
Copy link
Contributor Author

abhat commented Dec 11, 2020

This PR introduces a change to openshift-sdn kube-proxy which ovn-kubernetes doesn't use. the failing job e2e-aws-ovn-windows seems to be hitting a prow issue: Failed resolve MultiStageTestConfiguration: no workflow named openshift-upgrade-gcp

Overriding:

/override ci/prow/e2e-aws-ovn-windows

@openshift-ci-robot
Copy link
Contributor

@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-aws-ovn-windows

Details

In response to this:

This PR introduces a change to openshift-sdn kube-proxy which ovn-kubernetes doesn't use. the failing job e2e-aws-ovn-windows seems to be hitting a prow issue: Failed resolve MultiStageTestConfiguration: no workflow named openshift-upgrade-gcp

Overriding:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ec15689 into openshift:master Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1906844 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

astoycos pushed a commit to astoycos/cluster-network-operator that referenced this pull request Dec 16, 2020
Bug 1906844: Disable EndpointSlice and EndpointSliceProxying feature gates and update to k8s 1.19.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants