Skip to content

[WIP] -- DO NOT MERGE -- explicitly handle "no child processes" error #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frobware wants to merge 1 commit into from
Closed

[WIP] -- DO NOT MERGE -- explicitly handle "no child processes" error #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/router/template/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"os/exec"
"path/filepath"
"reflect"
"regexp"
"sort"
"strings"
"sync"
Expand All @@ -29,6 +30,7 @@ import (
)

var log = logf.Logger.WithName("template")
var noChildProcessesRegExp = regexp.MustCompile("[wait|waitid]: no child processes")

const (
ProtocolHTTP = "http"
Expand Down Expand Up @@ -542,7 +544,12 @@ func (r *templateRouter) writeCertificates(cfg *ServiceAliasConfig) error {
func (r *templateRouter) reloadRouter() error {
cmd := exec.Command(r.reloadScriptPath)
out, err := cmd.CombinedOutput()
if err != nil {
// Explicitly handle the case where the process has exited
// cleanly before we hit the call to wait() in
// CombinedOutput(). The logic there calls Start(), then
// Wait() and that could be racy if there is a GC pause (or
// other scheduling activity).
if err != nil && !noChildProcessesRegExp.MatchString(err.Error()) {
return fmt.Errorf("error reloading router: %v\n%s", err, string(out))
}
log.V(0).Info("router reloaded", "output", string(out))
Expand Down