Skip to content

[WIP] -- DO NOT MERGE -- explicitly handle "no child processes" error #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frobware wants to merge 1 commit into from
Closed

[WIP] -- DO NOT MERGE -- explicitly handle "no child processes" error #80

frobware wants to merge 1 commit into from

Conversation

@frobware
Copy link
Contributor

@frobware frobware commented Jan 8, 2020

DO NOT MERGE. Testing #78 in 4.3.

@frobware
template/router: explicitly handle "no child processes" error
262a20b 
When calling the router-reload script we would occasionally get:

```console
limiter.go:140 error reloading router: waitid: no child processes
```

In a CI run this could happen two/three times.

In cmd.Run() there is a potential race condition--the process is
started and then we wait for it. The process could complete and exit
before the call to wait because of, say, garbage collection.

We now explicitly swallow the error if it matches:
- wait: no child processes
- waitid: no child processes
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@frobware: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[WIP] -- DO NOT MERGE -- explicitly handle "no child processes" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frobware
To complete the pull request process, please assign pweil-
You can assign the PR to them by writing /assign @pweil- in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Contributor Author

frobware commented Jan 10, 2020

No longer needed. All experiments are in #78.

@frobware frobware closed this Jan 10, 2020
@frobware frobware deleted the handle-race-in-cmd-CombinedOutput-for-release-4.3 branch May 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frobware @openshift-ci-robot