[release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2 by openshift-cherrypick-robot · Pull Request #200 · openshift/router

openshift-cherrypick-robot · 2020-10-07T23:41:37Z

This is an automated cherry-pick of #194

/assign Miciah

Enable HTX if HTTP/2 is enabled, and turn off HTX otherwise. Enabling HTX causes HAProxy to down-case HTTP header names, which breaks non-conformant legacy HTTP clients and servers. This commit fixes bug 1885414. https://bugzilla.redhat.com/show_bug.cgi?id=1885414 * images/router/haproxy/conf/haproxy-config.template: Turn off HTX if HTTP/2 is not enabled.

openshift-ci-robot · 2020-10-07T23:41:47Z

@openshift-cherrypick-robot: Bugzilla bug 1885414 has been cloned as Bugzilla bug 1886214. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2

Details

In response to this:

[release-4.5] Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-07T23:42:08Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1886214, which is invalid:

expected dependent Bugzilla bug 1885414 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1885414 to target a release in 4.6.0, 4.6.z, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-07T23:43:42Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`23415f0`	link	`/test verify`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Miciah · 2020-10-08T02:47:46Z

Blocked on the broken bitbucket.org/ww/goautoneg dependency, which #195 will fix.

Miciah · 2020-10-26T05:13:20Z

/test verify

Miciah · 2020-10-26T05:13:37Z

/bugzilla refresh

openshift-ci-robot · 2020-10-26T05:13:41Z

@Miciah: This pull request references Bugzilla bug 1886214, which is invalid:

expected dependent Bugzilla bug 1886213 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2020-11-10T17:35:24Z

/bugzilla refresh

openshift-ci-robot · 2020-11-10T17:35:27Z

@frobware: This pull request references Bugzilla bug 1886214, which is invalid:

expected dependent Bugzilla bug 1886213 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-11T01:25:32Z

/bugzilla cc-qa

openshift-ci-robot · 2020-11-11T01:25:36Z

@lihongan: This pull request references Bugzilla bug 1886214, which is invalid:

expected dependent Bugzilla bug 1886213 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-11-12T18:36:52Z

/hold
The bump to HAProxy 2.2 may break this change because HAProxy 2.2 removes the "http-use-htx" option (see BZ#1897039).

Miciah · 2020-11-16T21:58:36Z

Never mind; the bump to HAProxy 2.2 only affects OpenShift 4.7 because it requires a change to the Dockerfiles, and that change has not been backported to the earlier release branches.
/hold cancel

lihongan · 2020-11-25T03:03:32Z

/bugzilla refresh

openshift-ci-robot · 2020-11-25T03:03:37Z

@lihongan: This pull request references Bugzilla bug 1886214, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886213 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1886213 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-25T03:04:03Z

/bugzilla cc-qa

openshift-ci-robot · 2020-11-25T03:04:07Z

@lihongan: This pull request references Bugzilla bug 1886214, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886213 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1886213 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-11-25T06:03:19Z

/lgtm

see also https://bugzilla.redhat.com/show_bug.cgi?id=1886214#c4

Miciah · 2020-11-25T07:12:58Z

/approve

openshift-ci-robot · 2020-11-25T07:13:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongan, Miciah, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-26T02:11:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-11-26T03:51:11Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/router#200

Bugzilla bug 1886214 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned Miciah Oct 7, 2020

openshift-cherrypick-robot mentioned this pull request Oct 7, 2020

Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2 #194

Merged

openshift-ci-robot requested review from danehans and smarterclayton October 7, 2020 23:41

openshift-ci-robot changed the title ~~[release-4.5] Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2~~ [release-4.5] Bug 1886214: haproxy-config.template: Only enable HTX for HTTP/2 Oct 7, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 7, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 25, 2020

openshift-ci-robot requested a review from lihongan November 25, 2020 03:04

openshift-ci-robot assigned lihongan Nov 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 25, 2020

openshift-merge-robot merged commit 56a8855 into openshift:release-4.5 Nov 26, 2020

Conversation

openshift-cherrypick-robot commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

openshift-ci-robot commented Oct 7, 2020

Uh oh!

Miciah commented Oct 8, 2020

Uh oh!

Miciah commented Oct 26, 2020

Uh oh!

Miciah commented Oct 26, 2020

Uh oh!

openshift-ci-robot commented Oct 26, 2020

Uh oh!

frobware commented Nov 10, 2020

Uh oh!

openshift-ci-robot commented Nov 10, 2020

Uh oh!

lihongan commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

Miciah commented Nov 12, 2020

Uh oh!

Miciah commented Nov 16, 2020

Uh oh!

lihongan commented Nov 25, 2020

Uh oh!

openshift-ci-robot commented Nov 25, 2020

Uh oh!

lihongan commented Nov 25, 2020

Uh oh!

openshift-ci-robot commented Nov 25, 2020

Uh oh!

lihongan commented Nov 25, 2020

Uh oh!

Miciah commented Nov 25, 2020

Uh oh!

openshift-ci-robot commented Nov 25, 2020

Uh oh!

openshift-bot commented Nov 26, 2020

Uh oh!

openshift-ci-robot commented Nov 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants