Skip to content

Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2#194

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:BZ1885414-haproxy-config-dot-template-only-enable-HTX-for-HTTP-slash-2
Oct 7, 2020
Merged

Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2#194
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:BZ1885414-haproxy-config-dot-template-only-enable-HTX-for-HTTP-slash-2

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Oct 5, 2020

Enable HTX if HTTP/2 is enabled, and turn off HTX otherwise. Enabling HTX causes HAProxy to down-case HTTP header names, which breaks non-conformant legacy HTTP clients and servers.

  • images/router/haproxy/conf/haproxy-config.template: Turn off HTX if HTTP/2 is not enabled.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 5, 2020

@Miciah: This pull request references Bugzilla bug 1885414, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 5, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@sgreene570
Copy link
Contributor

sgreene570 commented Oct 6, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2020

@sgreene570: This pull request references Bugzilla bug 1885414, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link
Contributor

sgreene570 commented Oct 6, 2020

/retest

@sgreene570
Copy link
Contributor

sgreene570 commented Oct 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
haproxy-config.template: Only enable HTX for HTTP/2
eccf4a3 
Enable HTX if HTTP/2 is enabled, and turn off HTX otherwise.  Enabling HTX
causes HAProxy to down-case HTTP header names, which breaks non-conformant
legacy HTTP clients and servers.

This commit fixes bug 1885414.

https://bugzilla.redhat.com/show_bug.cgi?id=1885414

* images/router/haproxy/conf/haproxy-config.template: Turn off HTX if
HTTP/2 is not enabled.
@Miciah Miciah force-pushed the BZ1885414-haproxy-config-dot-template-only-enable-HTX-for-HTTP-slash-2 branch from 896609e to eccf4a3 Compare October 7, 2020 21:27
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@sgreene570
Copy link
Contributor

sgreene570 commented Oct 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 06b2777 into openshift:master Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2020

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 1885414 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1885414: haproxy-config.template: Only enable HTX for HTTP/2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 7, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 7, 2020

@Miciah: new pull request created: #199

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 7, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 7, 2020

@Miciah: new pull request created: #200

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 7, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 7, 2020

@Miciah: new pull request created: #201

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2020
Closed
Miciah added a commit to Miciah/cluster-ingress-operator that referenced this pull request Oct 13, 2020
@Miciah
TestForwardedHeaderPolicy*: Make case-insensitive
ef0c865 
Ignore case when comparing the expected response and the actual response in
the Forwarded header policy E2E tests.
openshift/router#194 turns off HAProxy's HTX option
when HTTP/2 is not enabled.  As a result, HAProxy does not down-case HTTP
header names.

* test/e2e/forwarded_header_policy_test.go (testRouteHeaders): Ignore case
when comparing the expected response and the actual response.
@Miciah Miciah mentioned this pull request Oct 13, 2020
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cluster-ingress-operator that referenced this pull request Oct 13, 2020
@Miciah
TestForwardedHeaderPolicy*: Make case-insensitive
646545c 
Ignore case when comparing the expected response and the actual response in
the Forwarded header policy E2E tests.
openshift/router#194 turns off HAProxy's HTX option
when HTTP/2 is not enabled.  As a result, HAProxy does not down-case HTTP
header names.

* test/e2e/forwarded_header_policy_test.go (testRouteHeaders): Ignore case
when comparing the expected response and the actual response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@frobware frobware Awaiting requested review from frobware

Assignees

@sgreene570 sgreene570

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Miciah @openshift-ci-robot @sgreene570 @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot