Skip to content

Bug 1837251: Add unsupported http/2 kill switch #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 27, 2020
Merged

Bug 1837251: Add unsupported http/2 kill switch #133

openshift-merge-robot merged 2 commits into from
May 27, 2020

Conversation

@frobware
Copy link
Contributor

@frobware frobware commented May 20, 2020

This is to support the kill functionality added by:

openshift/cluster-ingress-operator#401

@frobware
Add unsupported http/2 kill switch
cfbb8b5 
This is to support the kill functionality added by:

  openshift/cluster-ingress-operator#401
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2020

@frobware: This pull request references Bugzilla bug 1837251, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1837251: Add unsupported http/2 kill switch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@frobware frobware mentioned this pull request May 20, 2020
Merged
frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request May 21, 2020
@frobware
Add unsupported http/2 kill switch
0910cef 
Adding:

  ingress.operator.openshift.io/unsupported-disable-http2: "true"

to either an ingresscontroller or the ingress configuration will
disable HTTP/2 support in the router deployment.

The corresponding change for the router:

  openshift/router#133

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1837251
frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request May 21, 2020
@frobware
Add unsupported http/2 kill switch
81bdd81 
Adding:

  ingress.operator.openshift.io/unsupported-disable-http2: "true"

to either an ingresscontroller or the ingress configuration will
disable HTTP/2 support in the router deployment.

The corresponding change for the router:

  openshift/router#133

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1837251
danehans
danehans reviewed May 26, 2020
View reviewed changes
@frobware frobware requested a review from danehans May 26, 2020 19:29
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 26, 2020
Merged
@Miciah
Copy link
Contributor

Miciah commented May 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3177ebb into openshift:master May 27, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 27, 2020

@frobware: All pull requests linked via external trackers have merged: openshift/router#133, openshift/cluster-ingress-operator#405, openshift/cluster-ingress-operator#401. Bugzilla bug 1837251 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1837251: Add unsupported http/2 kill switch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware frobware deleted the bz_1837251 branch May 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@knobunc knobunc Awaiting requested review from knobunc

@danehans danehans Awaiting requested review from danehans

Assignees

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frobware @openshift-ci-robot @Miciah @danehans @openshift-merge-robot