Skip to content

Conversation

@frobware
Copy link
Contributor

Changes to let the ingress controller override the ingress config if
the annotation is present and disabled (i.e., "false").

This is a follow-up to #401.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 26, 2020
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1837251, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1837251: e2e: Rework http/2 e2e test for ingresscontroller precedence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
Changes to let the ingress controller override the ingress config if
the annotation is present and disabled (i.e., "false").
@frobware frobware force-pushed the bz_1837251-follow-up branch from b8f2dd4 to db50184 Compare May 26, 2020 18:09
@Miciah
Copy link
Contributor

Miciah commented May 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7bc27fa into openshift:master May 26, 2020
@openshift-ci-robot
Copy link
Contributor

@frobware: Some pull requests linked via external trackers have merged: openshift/cluster-ingress-operator#401, openshift/cluster-ingress-operator#405. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1837251: e2e: Rework http/2 e2e test for ingresscontroller precedence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants