Skip to content

Conversation

@dcbw
Copy link
Contributor

@dcbw dcbw commented Jun 18, 2020

Ensures changes to MCO (like openshift/machine-config-operator#1636)
don't break ovn-kubernetes, Windows, hybrid overlay, etc.

@runcom @squeed

Ensures changes to MCO (like openshift/machine-config-operator#1636)
don't break ovn-kubernetes, Windows, hybrid overlay, etc.
@vishnoianil
Copy link
Contributor

LGTM

@runcom
Copy link
Member

runcom commented Jun 18, 2020

LGTM one qq tho: this test will be optional but its success rate is pretty high right? we just don't want to have to skip it on the majority of the PRs we have (so it's valuable to have it run anyway)

@runcom
Copy link
Member

runcom commented Jun 18, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@ashcrow ashcrow requested review from runcom and removed request for ashcrow June 18, 2020 15:35
@trozet
Copy link
Contributor

trozet commented Jun 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, runcom, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trozet
Copy link
Contributor

trozet commented Jun 22, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 16de9c3 into openshift:master Jun 22, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: Updated the following 9 configmaps:

  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
Details

In response to this:

Ensures changes to MCO (like openshift/machine-config-operator#1636)
don't break ovn-kubernetes, Windows, hybrid overlay, etc.

@runcom @squeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants