-
Notifications
You must be signed in to change notification settings - Fork 463
Revert "Start openvswitch and ovsdb-server when network is ovn/ovs" #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Start openvswitch and ovsdb-server when network is ovn/ovs" #1830
Conversation
This reverts commit be883a8.
|
/skip |
|
Filed a quick PR to adopt host openvswitch - openshift/cluster-network-operator#672 - if that merges, we won't need this. |
|
/test e2e-gcp-upgrade |
|
672 should be good to go; just needs review. It passed enough CI to give me confidence that it's fine. |
|
Nevermind, upgrades are failing. Let's revert |
|
/refresh |
|
/skip |
|
/retest |
|
/skip |
|
/retest |
|
I am OK with this revert but I do not have green button access. |
|
any owner can "/override ci/prow-e2e-gcp-upgrade" |
|
/override ci/prow-e2e-gcp-upgrade |
|
/override ci/prow/e2e-gcp-upgrade |
|
@ashcrow: /override requires a failed status context to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-upgrade |
|
@ashcrow: /override requires a failed status context to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-upgrade |
|
@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, runcom, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This may be stuck. According to the tide details link everything is in order ... |
|
Scratch that: |
|
/override ci/prow/e2e-gcp-upgrade |
|
@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp-upgrade |
|
@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Since this is causing issues in CI I'm going to override the retests to get CI working again. |
|
/override ci/prow/e2e-aws |
|
@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-aws, ci/prow/e2e-gcp-op DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/images |
|
@ashcrow: /override requires a failed status context to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/images |
|
@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Would it help if the repo had e2e tests run against an OVN cluster too? That way such issues can be caught in the PR itself. The SDN team has also made it easy by adding step registry flows ( ipi-aws-ovn-hybrid, openshift-e2e-aws-ovn) for bringing up an OVN cluster. |
|
Yes, it certainly would help to have a gating test for e2e-aws-ovn at least. |
+1 |
This reverts commit be883a8.
This is related to #1636
Holding pending @squeed and @mccv1r0 tests
/hold