Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Jun 16, 2020

This reverts commit be883a8.

This is related to #1636

Holding pending @squeed and @mccv1r0 tests

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@runcom
Copy link
Member Author

runcom commented Jun 16, 2020

/skip
/retest

@squeed
Copy link
Contributor

squeed commented Jun 16, 2020

Filed a quick PR to adopt host openvswitch - openshift/cluster-network-operator#672 - if that merges, we won't need this.

@abhat
Copy link
Contributor

abhat commented Jun 16, 2020

/test e2e-gcp-upgrade

@vishnoianil
Copy link

@squeed if #672 is gonna take time, we should merge this PR, because most of the gcp-ovn ci jobs seems to be failing because of the original PR of this revert.

@squeed
Copy link
Contributor

squeed commented Jun 17, 2020

672 should be good to go; just needs review. It passed enough CI to give me confidence that it's fine.

@squeed
Copy link
Contributor

squeed commented Jun 17, 2020

Nevermind, upgrades are failing. Let's revert
/lgtm
:-(

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@runcom
Copy link
Member Author

runcom commented Jun 17, 2020

/refresh
/retest

@runcom runcom removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@runcom
Copy link
Member Author

runcom commented Jun 17, 2020

/skip

@runcom
Copy link
Member Author

runcom commented Jun 17, 2020

/retest

@runcom
Copy link
Member Author

runcom commented Jun 17, 2020

/skip

@runcom
Copy link
Member Author

runcom commented Jun 17, 2020

/retest

@dcbw
Copy link
Contributor

dcbw commented Jun 17, 2020

@runcom @eparis I think we just need to green-button this one to unblock our 4.6 CI.

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

I am OK with this revert but I do not have green button access.

@squeed
Copy link
Contributor

squeed commented Jun 17, 2020

any owner can "/override ci/prow-e2e-gcp-upgrade"

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

/override ci/prow-e2e-gcp-upgrade

@knobunc
Copy link
Contributor

knobunc commented Jun 17, 2020

/override ci/prow/e2e-gcp-upgrade
/override ci/prow/e2e-metal-ipi

@openshift-ci-robot
Copy link
Contributor

@ashcrow: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow-e2e-gcp-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/images
  • tide
Details

In response to this:

/override ci/prow-e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-gcp-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/images
  • tide
Details

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift openshift deleted a comment from openshift-ci-robot Jun 17, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jun 17, 2020
@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, runcom, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

This may be stuck. According to the tide details link everything is in order ...

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

Scratch that: In Pool - In Batch & Test Pending

@ashcrow
Copy link
Member

ashcrow commented Jun 17, 2020

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 18, 2020

@runcom: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 59ce0a6 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow
Copy link
Member

ashcrow commented Jun 18, 2020

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Jun 18, 2020

Since this is causing issues in CI I'm going to override the retests to get CI working again.

@ashcrow
Copy link
Member

ashcrow commented Jun 18, 2020

/override ci/prow/e2e-aws
/override ci/prow/e2e-gcp-op

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-aws, ci/prow/e2e-gcp-op

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Jun 18, 2020

/override ci/prow/images

@openshift-ci-robot
Copy link
Contributor

@ashcrow: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/images

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide
Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Jun 18, 2020

/override ci/prow/images

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 064075f into openshift:master Jun 18, 2020
@runcom runcom deleted the start-services-ovn-ovs-revert branch June 18, 2020 13:04
@aravindhp
Copy link
Contributor

Would it help if the repo had e2e tests run against an OVN cluster too? That way such issues can be caught in the PR itself. The SDN team has also made it easy by adding step registry flows ( ipi-aws-ovn-hybrid, openshift-e2e-aws-ovn) for bringing up an OVN cluster.

@dcbw
Copy link
Contributor

dcbw commented Jun 18, 2020

Yes, it certainly would help to have a gating test for e2e-aws-ovn at least.

@vishnoianil
Copy link

Yes, it certainly would help to have a gating test for e2e-aws-ovn at least.

+1

@dcbw
Copy link
Contributor

dcbw commented Jun 18, 2020

openshift/release#9767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.