Skip to content

Conversation

@jstuever
Copy link
Contributor

@jstuever jstuever commented Jun 8, 2020

This change updates the upi-gcp-install step to be able to use the full
word 'worker' in the name of compute nodes. It maintains
compatiblity with the the older 'w' naming convention by looking at
if 'm' or 'master' is used in control_plane.py per #9490.

openshift/installer#3713
#9490

This change updates the upi-gcp-install step to be able to use the full
word 'worker' in the name of compute nodes. It maintains
compatiblity with the the older 'w' naming convention by looking at
if 'm' or 'master' is used in control_plane.py per openshift#9490.

openshift/installer#3713
openshift#9490
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@jstuever
Copy link
Contributor Author

jstuever commented Jun 8, 2020

/retest

@jstuever
Copy link
Contributor Author

jstuever commented Jun 9, 2020

Same as #9490 (comment)... openshift/installer#3713 is designed to work around this bug but it requires this PR merge first.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b93fb04 into openshift:master Jun 9, 2020
@openshift-ci-robot
Copy link
Contributor

@jstuever: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key upi-install-gcp-commands.sh using file ci-operator/step-registry/upi/install/gcp/upi-install-gcp-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key upi-install-gcp-commands.sh using file ci-operator/step-registry/upi/install/gcp/upi-install-gcp-commands.sh
Details

In response to this:

This change updates the upi-gcp-install step to be able to use the full
word 'worker' in the name of compute nodes. It maintains
compatiblity with the the older 'w' naming convention by looking at
if 'm' or 'master' is used in control_plane.py per #9490.

openshift/installer#3713
#9490

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever jstuever deleted the gcp_relax_clustername branch November 11, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants