upi-gcp-install: enable 'master' name for control plane

[jstuever]

This change updates the upi-gcp-install step to be able to use the full
word 'master' in the name of control plane nodes. It maintains
compatiblity with the the older 'm' naming convention by looking at
which one was used in the 05_control_plane.py template.

openshift/installer#3713

[abhinavdahiya]

qq: is there no way to request the information from the deploymentmanager template that was deployed. i.e all the resources it created?

[jstuever]

There likely is, but that's not what is in our documentation. I'd like to make sure we are sticking to documentation as much as possible, since that's the point.

[jstuever]

/test pj-rehearse

[openshift-ci-robot]

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-gcp-upi	2695133	link	/test pj-rehearse
ci/prow/pj-rehearse	2695133	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jstuever]

Running into the following bug https://bugzilla.redhat.com/show_bug.cgi?id=1844613:

Jun 05 16:56:35 ci-op-w41w3lff-42368-qqkxn-m-0.c.openshift-gce-devel-ci.internal hyperkube[1532]: E0605 16:56:35.306854    1532 kubelet_node_status.go:92] Unable to register node "ci-op-w41w3lff-42368-qqkxn-m-0.c.openshift-gce-devel-ci.internal" with API server: Node "ci-op-w41w3lff-42368-qqkxn-m-0.c.openshift-gce-devel-ci.internal" is invalid: metadata.labels: Invalid value: "ci-op-w41w3lff-42368-qqkxn-m-0.c.openshift-gce-devel-ci.internal": must be no more than 63 characters

PR openshift/installer#3713 is designed to work around this bug, but it requires this PR to merge first.

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/upi/install/gcp/OWNERS [abhinavdahiya,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jstuever: Updated the following 2 configmaps:

• step-registry configmap in namespace ci at cluster api.ci using the following files:
  • key upi-install-gcp-commands.sh using file ci-operator/step-registry/upi/install/gcp/upi-install-gcp-commands.sh
• step-registry configmap in namespace ci at cluster app.ci using the following files:
  • key upi-install-gcp-commands.sh using file ci-operator/step-registry/upi/install/gcp/upi-install-gcp-commands.sh

Details

In response to this:

This change updates the upi-gcp-install step to be able to use the full
word 'master' in the name of control plane nodes. It maintains
compatiblity with the the older 'm' naming convention by looking at
which one was used in the 05_control_plane.py template.

openshift/installer#3713

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.