Skip to content

Conversation

@damemi
Copy link

@damemi damemi commented May 19, 2020

@damemi damemi force-pushed the resourcewatch-gcp-upgrade branch 2 times, most recently from 72fc97a to 7c7cf00 Compare May 19, 2020 18:33
@deads2k
Copy link
Contributor

deads2k commented May 19, 2020

/lgtm
/hold

holding so we can get confirmation that some kind of a rehearsal did a thing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@damemi damemi force-pushed the resourcewatch-gcp-upgrade branch from 7c7cf00 to 201ab51 Compare May 20, 2020 18:38
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@damemi
Copy link
Author

damemi commented May 20, 2020

Adding the changes from #9200

@openshift-ci-robot
Copy link
Contributor

@damemi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/core-valid 201ab51 link /test core-valid
ci/prow/services-valid 201ab51 link /test services-valid
ci/rehearse/openshift/openshift-ansible/release-3.10/gcp-major-upgrade 201ab51 link /test pj-rehearse
ci/prow/pj-rehearse 201ab51 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented May 27, 2020

per https://coreos.slack.com/archives/CBN38N3MW/p1590000428406000?thread_ts=1589915598.371500&cid=CBN38N3MW this cannot be rehearsed.

We need to track the history to fix CI blockers like, "why does the kube-apiserver appear to drop out" and "is this degraded at the instant when this fails".

Without the ability to rehearse, I guess we just go for it.

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi, deads2k
To complete the pull request process, please assign vrutkovs
You can assign the PR to them by writing /assign @vrutkovs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants