Add resourcewatch controller to e2e-operator test for KAS-O

[damemi]

This implements the run-resourcewatch config change watcher for kube-apiserver-operator's e2e (openshift/origin#24845)

[damemi]

/retest

[tnozicka]

Are you tarring while the writer is still running? You need to stop it first as was suggested in the Slack thread.

[damemi]

I was wondering about that, the only way I can think to stop the controller is by killing the process because it doesn't really have a "stop" condition, so we can't just wait for it to end. After the e2e test runs, there shouldn't be any more changes to the configs right?
@mfojtik @sanchezl

[damemi]

/retest

[damemi]

/retest

[deads2k]

graceful kill doesn't work?

[deads2k]

/lgtm
/hold

you need green proof

@damemi if this works, how do we do this enable it for all jobs?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-kube-apiserver-operator/OWNERS [deads2k]
• ci-operator/jobs/openshift/cluster-kube-apiserver-operator/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@damemi: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/cluster-kube-apiserver-operator/master/e2e-aws-operator	db28946	link	/test pj-rehearse
ci/prow/pj-rehearse	db28946	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[damemi]

Seeing this error when it tries to run: /bin/bash: line 77: openshift-tests: command not found. @tnozicka or @sanchezl any idea where the openshift-tests binary would be in this case?

[damemi]

Fixing the missing binary test will rely on openshift/cluster-kube-apiserver-operator#844

[damemi]

This is still blocked on the discussion in openshift/cluster-kube-apiserver-operator#844 (comment)

Specifically, we need to make the binary available in the operator image by copying it from the builder. But we only want to have it available in CI. I couldn't find any way to conditionally do the docker COPY so if we can't figure that out, we'll either need to always copy the openshift-tests binary or do this somewhere besides the operator e2e

[deads2k]

This is still blocked on the discussion in openshift/cluster-kube-apiserver-operator#844 (comment)

Specifically, we need to make the binary available in the operator image by copying it from the builder. But we only want to have it available in CI. I couldn't find any way to conditionally do the docker COPY so if we can't figure that out, we'll either need to always copy the openshift-tests binary or do this somewhere besides the operator e2e

put in the image in the openshift-test image, right?

[damemi]

/close

[openshift-ci-robot]

@damemi: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.