Skip to content

DNS: Add nvidia.eng.rdu2.dc.redhat.com zone - #83272

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
josecastillolema:dns-nvidia
Aug 11, 2026
Merged

DNS: Add nvidia.eng.rdu2.dc.redhat.com zone#83272
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
josecastillolema:dns-nvidia

Conversation

@josecastillolema

@josecastillolema josecastillolema commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Adds the nvidia.eng.rdu2.dc.redhat.com DNS zone to the rh-intranet server configuration.
  • Enables DNS management for NVIDIA engineering infrastructure in the RDU2 environment.

Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>

    gitleaks.version: 8.30.0
    gitleaks.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: aae78ac7-d876-476d-8de6-7fdf105ef61a

📥 Commits

Reviewing files that changed from the base of the PR and between 73a24d9 and d933fa8.

📒 Files selected for processing (1)
  • clusters/build-clusters/build-shared/managed/dns.yaml

Walkthrough

The rh-intranet DNS server configuration now includes the nvidia.eng.rdu2.dc.redhat.com zone.

Changes

Intranet DNS zone update

Layer / File(s) Summary
Configure NVIDIA DNS zone
clusters/build-clusters/build-shared/managed/dns.yaml
The rh-intranet DNS server now lists nvidia.eng.rdu2.dc.redhat.com in its zones.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: fracappa

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the DNS zone added by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only a static DNS zone entry; no Ginkgo test titles or dynamic test-name values are introduced.
Test Structure And Quality ✅ Passed The pull request changes only one DNS YAML file by adding a zone entry; it adds no Ginkgo tests or cluster operations to review.
Microshift Test Compatibility ✅ Passed The pull request changes only a DNS YAML zone list and adds no Ginkgo tests or test references to MicroShift-unsupported APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only one DNS YAML zone entry and adds no Ginkgo tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The only change adds a DNS zone to a DNS custom resource; it adds no deployment, operator, controller, replica, affinity, selector, taint, or disruption scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only the DNS YAML zone list; it adds no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only managed DNS YAML by adding one zone; it adds no Ginkgo tests, IPv4 assumptions, or test connectivity requirements.
No-Weak-Crypto ✅ Passed The commit adds only the DNS zone nvidia.eng.rdu2.dc.redhat.com; the patch contains no weak-crypto or secret-comparison usage.
Container-Privileges ✅ Passed The PR adds only one DNS zone entry. The changed DNS manifest and patch contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or privilege-escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds one internal hostname to a DNS zones list; it adds no logging statement or password, token, API key, PII, session ID, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deepsm007 and droslean August 11, 2026 15:22
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@josecastillolema: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@josecastillolema: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bear-redhat

Copy link
Copy Markdown
Contributor

/lgtm

@bear-redhat

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, josecastillolema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 9e09e81 into openshift:main Aug 11, 2026
9 checks passed
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>

    gitleaks.version: 8.30.0
    gitleaks.check-secrets: ENABLED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants