USHIFT-6923: dns: add paas.redhat.com to intranet forward zones

[fracappa]

MicroShift crypto scanner needs to pull images from images.paas.redhat.com, which requires intranet DNS resolution

Summary by CodeRabbit

• Adds paas.redhat.com to the rh-intranet DNS forward zones.
• Enables the MicroShift crypto scanner to resolve images.paas.redhat.com and pull required images.

[coderabbitai]

Walkthrough

The DNS configuration adds paas.redhat.com to the rh-intranet server zone list.

Changes

DNS zone update

Layer / File(s)	Summary
Add paas.redhat.com zone clusters/build-clusters/build-shared/managed/dns.yaml	The rh-intranet DNS server now includes the paas.redhat.com zone.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: droslean, jmguzik

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only a DNS YAML zone list by adding the static value paas.redhat.com; it changes no Ginkgo tests or test titles.
Test Structure And Quality	✅ Passed	The pull request changes only the DNS YAML manifest; it adds no Ginkgo tests or test operations for these quality requirements.
Microshift Test Compatibility	✅ Passed	The pull request changes only a DNS YAML file and adds no Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only DNS configuration by adding paas.redhat.com; it adds no Ginkgo e2e tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only the DNS forward-zone list by adding paas.redhat.com; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The commit changes only a DNS YAML zone list; it adds no Go, OTE, main, suite setup, or stdout-writing code, so the binary stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only managed DNS YAML by adding paas.redhat.com; it adds no Ginkgo e2e tests or test connectivity assumptions.
No-Weak-Crypto	✅ Passed	The only change adds paas.redhat.com to a DNS zone list; the PR diff contains no weak cryptography or secret/token comparisons.
Container-Privileges	✅ Passed	The PR adds only paas.redhat.com to a kind: DNS zone list; it adds no container manifest or privileged setting.
No-Sensitive-Data-In-Logs	✅ Passed	The patch adds one DNS zone entry only; it introduces no logging statements, secret-like values, or log configuration changes that expose sensitive data.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the DNS change and the addition of paas.redhat.com to the intranet forward zones.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[fracappa]

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

[openshift-merge-bot]

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@fracappa: no rehearsal-relevant files were changed in this PR

[fracappa]

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

[openshift-merge-bot]

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@fracappa: no rehearsal-relevant files were changed in this PR

[fracappa]

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

[openshift-merge-bot]

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[fracappa]

/pj-rehearse pull-ci-openshift-microshift-main-test-rebase

[openshift-merge-bot]

@fracappa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-merge-bot]

@fracappa, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo207083476/ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "dns_config"

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-commands.sh`:
- Around line 16-17: Update the checkout commands around git fetch and git
checkout to fetch from an approved allowlisted repository at a fixed, reviewed
commit SHA rather than the mutable fca/add-ushift-cbom branch. Ensure the pinned
revision is checked out before any credential-bearing scripts run, including the
commands using ci-pull-credentials and pr-creds; if pinning is unavailable, move
this checkout and its execution into an environment without those credentials.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 84745010-d65c-4685-b6eb-2bc48edf2b4f

📥 Commits

Reviewing files that changed from the base of the PR and between 88ce08f and 1a7f2a3.

📒 Files selected for processing (3)

• ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-commands.sh
• ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml
• clusters/build-clusters/build-shared/managed/dns.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• clusters/build-clusters/build-shared/managed/dns.yaml

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Pin the checked-out source before exposing CI credentials.

Lines 16-17 fetch a mutable branch from a fork-owned repository. Line 19 then executes scripts from that checkout. The ref file mounts ci-pull-credentials and pr-creds at Lines 24-30, and Line 13 copies the pull secret before this checkout. A branch update or repository compromise can therefore run code with access to CI credentials.

Use an approved commit SHA from an allowlisted repository. If the source cannot be pinned, isolate the checkout from the credential-bearing execution environment.

Suggested hardening

-git fetch https://github.com/fracappa/microshift.git fca/add-ushift-cbom
-git checkout FETCH_HEAD
+expected_commit="<approved-commit-sha>"
+git fetch --no-tags https://github.com/fracappa/microshift.git fca/add-ushift-cbom
+test "$(git rev-parse FETCH_HEAD)" = "${expected_commit}"
+git checkout --detach FETCH_HEAD

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-commands.sh`
around lines 16 - 17, Update the checkout commands around git fetch and git
checkout to fetch from an approved allowlisted repository at a fixed, reviewed
commit SHA rather than the mutable fca/add-ushift-cbom branch. Ensure the pinned
revision is checked out before any credential-bearing scripts run, including the
commands using ci-pull-credentials and pr-creds; if pinning is unavailable, move
this checkout and its execution into an environment without those credentials.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@fracappa: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci-robot]

@fracappa: This pull request references USHIFT-6923 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

MicroShift crypto scanner needs to pull images from images.paas.redhat.com, which requires intranet DNS resolution

Summary by CodeRabbit

• Adds paas.redhat.com to the rh-intranet DNS forward zones.
• Enables the MicroShift crypto scanner to resolve images.paas.redhat.com and pull required images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, fracappa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• clusters/build-clusters/build-shared/OWNERS [deepsm007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@fracappa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-operator-registry	1a7f2a3	link	true	/test ci-operator-registry
ci/prow/ci-operator-config	1a7f2a3	link	true	/test ci-operator-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.