Map OKD stream names to canonical types for autodl JSON - #82266
openshift-merge-bot[bot] merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe payload agent maps ChangesCanonical stream mapping
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-openshift-release-main-payload-agent-analyze |
|
@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| # Canonical stream type for BigQuery autodl schema (must be "nightly" or "ci") | ||
| # OCP streams already use canonical names; OKD streams need mapping. | ||
| case "${STREAM}" in | ||
| okd-scos-nightly) STREAM_TYPE="nightly" ;; |
There was a problem hiding this comment.
we could just reassign to STREAM rather than a new var
There was a problem hiding this comment.
Yes, makes sense. Made the changes @Prashanth684
d547cbd to
db0808e
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-payload-agent-analyze |
|
@pskrbasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: pskrbasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@pskrbasu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
STREAM_TYPEmapping to convert OKD stream names to canonical BigQuery values (nightly/ci)okd-scos-nightlyandokd-scos, but the autodl JSON schema requires canonicalnightlyorciWhy this is needed
The payload agent job for OKD SCOS (#80392, #81940) runs successfully but fails validation at the end. The autodl JSON validator rejects
stream: "okd-scos-nightly"because it only accepts"nightly"or"ci". See the failed run: Prow logsThis fixes the
generate_accepted_autodl()function in the shell script (accepted payload path). For rejected payloads, Claude generates the autodl JSON independently — the companion PR openshift-eng/ai-helpers#636 updates the SKILL.md docs so Claude applies the same mapping.Companion PR
streamfield docs in the payload-autodl-json skill so Claude maps OKD streams to canonical values for rejected payloadsWhat changed
Added a
casestatement afterSTREAMextraction that maps OKD stream names to canonical types:okd-scos-nightly→nightlyokd-scos→ciBackward compatibility
OCP payloads produce
STREAM=nightlyorSTREAM=ci, which hit the*)wildcard and pass through as-is. No change in behavior for OCP.Summary by CodeRabbit
Updates the OpenShift CI infrastructure used for Claude’s accepted-payload generation. The
openshift-claude-payload-agent-commands.shscript now normalizes OKD stream identifiers extracted from payload tags to match the autodl JSON schema:okd-scos-nightly→nightlyokd-scos→ciThis avoids autodl validation failures caused by OKD stream names, while leaving existing OCP behavior unchanged.