CNTRLPLANE-3755: add optional e2e-aws-backport job for hypershift release branches - #82169
CNTRLPLANE-3755: add optional e2e-aws-backport job for hypershift release branches#82169PoornimaSingour wants to merge 2 commits into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@PoornimaSingour: This pull request references CNTRLPLANE-3755 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (10)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe release configurations add optional AWS backport E2E jobs for HyperShift releases 4.14 through 5.1. Selected configurations also build ChangesHyperShift AWS backport testing
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds optional backport end-to-end jobs without an identified current-head correctness or merge-readiness issue; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (12 skipped: 12 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes CI YAML and generated Prow manifests only. It does not add or modify Ginkgo Full details: Test Structure And QualityExplanation PASS — The pull request changes only Hypershift CI configuration and generated Prow YAML. The diff contains no Ginkgo test source, Full details: Microshift Test CompatibilityExplanation The check is not applicable. The PR changes only YAML CI configuration files. The final diff contains 29 YAML files and no Go, Ginkgo, or test source files. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only Hypershift CI YAML files. The diff adds the Full details: Topology-Aware Scheduling CompatibilityExplanation PASS. The PR changes only Hypershift CI configuration and generated Prow job YAML. The added fields define the Full details: Ote Binary Stdout ContractExplanation PASS: The net pull-request diff contains only YAML configuration and generated Prow job files. It adds the Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS. The PR-side diff contains 29 YAML changes and no Go or Ginkgo test source changes. The new job only selects existing Full details: No-Weak-CryptoExplanation PASS: The PR delta is limited to 29 YAML configuration files. The added job and generated Prow entries only define CI images, workflows, dependencies, test filters, and secret mounts. Searches of all PR-added lines found no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, crypto API, HMAC, or constant-time comparison usage. No custom crypto implementation or secret comparison was introduced. Full details: Container-PrivilegesExplanation PASS. The PR changes only Hypershift CI YAML and generated Prow job YAML. The added Full details: No-Sensitive-Data-In-LogsExplanation PASS: The PR changes only YAML CI declarations and generated Prow jobs. The new ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19.yaml`:
- Around line 177-180: Add OCP_IMAGE_N3 mapped to release:n3minor and
OCP_IMAGE_N4 mapped to release:n4minor in the dependencies section alongside
OCP_IMAGE_N1 and OCP_IMAGE_N2, so the nested tests use the configured N3/N4
release images instead of release:latest.
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20.yaml`:
- Around line 181-184: Add OCP_IMAGE_N3 mapped to release:n3minor and
OCP_IMAGE_N4 mapped to release:n4minor in the dependencies section, alongside
OCP_IMAGE_N1 and OCP_IMAGE_N2, so the hypershift-aws-e2e-nested workflow uses
the configured older release images.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2e7057e4-22af-4331-bd86-1a53e7108143
⛔ Files ignored due to path filters (5)
ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (13)
ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.18.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.19.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.20.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.21.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.22.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.23.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-5.0.yamlci-operator/config/openshift-priv/origin/openshift-priv-origin-release-5.1.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22.yaml
💤 Files with no reviewable changes (9)
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.23.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-5.1.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.22.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.18.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.20.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-5.0.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.19.yaml
- ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.21.yaml
|
/retest |
|
/pj-rehearse e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): e2e-aws-backport either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-4.21-e2e-aws-backport pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-4.21-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
needs-rebase
|
@PoornimaSingour, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aws-backport pull-ci-openshift-hypershift-release-4.18-e2e-aws-backport pull-ci-openshift-hypershift-release-4.17-e2e-aws-backport pull-ci-openshift-hypershift-release-4.16-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.18-e2e-aws-backport pull-ci-openshift-hypershift-release-4.17-e2e-aws-backport pull-ci-openshift-hypershift-release-4.16-e2e-aws-backport pull-ci-openshift-hypershift-release-4.15-e2e-aws-backport pull-ci-openshift-hypershift-release-4.14-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
78c7a90 to
ed99fbc
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-4.23-e2e-aws-backport pull-ci-openshift-hypershift-release-5.0-e2e-aws-backport pull-ci-openshift-hypershift-release-5.1-e2e-aws-backport pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backpor |
|
@PoornimaSingour: your |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-4.23-e2e-aws-backport pull-ci-openshift-hypershift-release-5.0-e2e-aws-backport pull-ci-openshift-hypershift-release-5.1-e2e-aws-backport pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backpor |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/rebase |
…ranches Add hypershift-operator-pr image build to branches that were missing it (4.14-4.18, 4.23, 5.0, 5.1) so the e2e-aws-backport job can use HYPERSHIFT_RELEASE_LATEST: hypershift-operator-pr consistently across all release branches from 4.14 to 5.1.
ed99fbc to
bcf9fae
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-4.23-e2e-aws-backport pull-ci-openshift-hypershift-release-5.0-e2e-aws-backport pull-ci-openshift-hypershift-release-5.1-e2e-aws-backport pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backport pull-ci-openshift-hypershift-release-4.18-e2e-aws-backport pull-ci-openshift-hypershift-release-4.17-e2e-aws-backport pull-ci-openshift-hypershift-release-4.16-e2e-aws-backport pull-ci-openshift-hypershift-release-4.15-e2e-aws-backport pull-ci-openshift-hypershift-release-4.14-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): pull-ci-openshift-hypershift-release-4.23-e2e-aws-backport, either don't exist or were not found to be affected, and cannot be rehearsed |
Enable TechPreview APIs for the 4.18 backport job and use explicit AMD64 OCP images for 4.20. Regenerate the 5.0 and 5.1 Prow jobs with their ARM64 capability labels.
|
[REHEARSALNOTIFIER]
A total of 331 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.22-e2e-aws-backport pull-ci-openshift-hypershift-release-5.0-e2e-aws-backport pull-ci-openshift-hypershift-release-5.1-e2e-aws-backport pull-ci-openshift-hypershift-release-4.20-e2e-aws-backport pull-ci-openshift-hypershift-release-4.19-e2e-aws-backport pull-ci-openshift-hypershift-release-4.18-e2e-aws-backport pull-ci-openshift-hypershift-release-4.17-e2e-aws-backport pull-ci-openshift-hypershift-release-4.16-e2e-aws-backport pull-ci-openshift-hypershift-release-4.15-e2e-aws-backport pull-ci-openshift-hypershift-release-4.14-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws-backport |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
** Add an optional
e2e-aws-backportjob to hypershift release branches 4.14,4.15,4.16,4.17,4.18, 4.19, 4.20, 4.21, 4.22, 5.0 and 5.1 Release branch CI jobs currently install usinghypershift-operator:latestfrom main, not the PR-built image. This means backported HO changes are never tested before merge. The new job overridesHYPERSHIFT_RELEASE_LATESTto usehypershift-operator-pr(the PR-built image) and is triggerable on demand via/test e2e-aws-backport.Test plan
make jobspasses locally (checkconfig + prowgen + sanitize)/test e2e-aws-backporton a hypershift backport PR to validate end-to-endRelated
🤖 Generated with Claude Code
Summary by CodeRabbit
e2e-aws-backportjobs to HyperShift release configurations.hypershift-operator-primages with latest-release installation and cluster-creation tests.TEST_FUNCparameter and a stale generated Prow job.make jobspasses locally. Prow rehearsal and end-to-end validation remain pending.