OCPBUGS-98640: Remove branch filter from pipeline controller hypershift config (again)

[bryan-cox]

Summary

• PR Add hypershift release-4.22 to pipeline controller lgtm-config #79626 removed the main-only branch filter from the pipeline controller lgtm-config for hypershift so e2e jobs would trigger on all branches (including release branches)
• PR Enroll 23 single-e2e payload repos in pipeline controller LGTM mode #81599 inadvertently re-added the main-only branch filter when bulk-enrolling 23 repos, causing release-4.22 PRs to merge without e2e coverage again (e.g. [release-4.22] OCPBUGS-98627: Skip Azure topology LB scope override for ARO HCP IngressController hypershift#8998)
• Remove the branch filter to match the pattern used by other repos in the config

Test plan

• Verify pipeline controller triggers e2e jobs on release-4.22 PRs when lgtm is applied

🤖 Generated with Claude Code

Summary by CodeRabbit

• Updated the Hypershift pipeline-controller LGTM configuration to remove the main-only branch restriction.
• E2E jobs can now trigger for approved pull requests across all branches, including release branches such as release-4.22.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@bryan-cox: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[coderabbitai]

Walkthrough

The pipeline controller configuration simplifies the openshift organization’s hypershift repository entry, removing its explicit main branch selection.

Changes

Hypershift configuration

Layer / File(s)	Summary
Remove hypershift branch restriction core-services/pipeline-controller/lgtm-config.yaml	The hypershift entry changes from a main-branch object to a plain repository list entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mcornea

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only core-services/pipeline-controller/lgtm-config.yaml changed; no Ginkgo tests or titles were added or modified.
Test Structure And Quality	✅ Passed	Only lgtm-config.yaml changed; no Ginkgo test code or test patterns were modified, so the check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only edits lgtm-config.yaml to remove a branch filter; it adds no Ginkgo tests or API/resource usage to evaluate for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only edits lgtm-config.yaml; no Ginkgo tests or new multi-node/SNO-sensitive test code were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The only change is in lgtm-config repo enrollment; no deployment manifests, controllers, or scheduling constraints were added or modified.
Ote Binary Stdout Contract	✅ Passed	Only core-services/pipeline-controller/lgtm-config.yaml changed; no binary code or stdout-writing process setup was touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a YAML config entry changed; no new Ginkgo tests or network/IP logic were added, so the IPv6/disconnected test check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only edits a YAML repo list entry; no crypto algorithms, custom crypto, or secret comparisons are present.
Container-Privileges	✅ Passed	The only changed file is an lgtm repo list entry; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Only change is removing a branch filter in a YAML repo list; no log statements, secrets, or PII are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing the branch filter from the Hypershift pipeline controller config.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jparrill]

/lgtm

[jparrill]

/approve

[deepsm007]

/override ci/prow/core-valid

[deepsm007]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, deepsm007, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/pipeline-controller/OWNERS [deepsm007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/core-valid

Details

In response to this:

/override ci/prow/core-valid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-98640, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• PR Add hypershift release-4.22 to pipeline controller lgtm-config #79626 removed the main-only branch filter from the pipeline controller lgtm-config for hypershift so e2e jobs would trigger on all branches (including release branches)
• PR Enroll 23 single-e2e payload repos in pipeline controller LGTM mode #81599 inadvertently re-added the main-only branch filter when bulk-enrolling 23 repos, causing release-4.22 PRs to merge without e2e coverage again (e.g. [release-4.22] OCPBUGS-98627: Skip Azure topology LB scope override for ARO HCP IngressController hypershift#8998)
• Remove the branch filter to match the pattern used by other repos in the config

Test plan

• Verify pipeline controller triggers e2e jobs on release-4.22 PRs when lgtm is applied

🤖 Generated with Claude Code

Summary by CodeRabbit

• Updated the Hypershift pipeline-controller LGTM configuration to remove the main-only branch restriction.
• E2E jobs can now trigger for approved pull requests across all branches, including release branches such as release-4.22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/jira refresh

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-98640, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bryan-cox: Jira Issue OCPBUGS-98640: All pull requests linked via external trackers have merged:

• openshift/release#81855

Jira Issue OCPBUGS-98640 has been moved to the MODIFIED state.

Details

In response to this:

Summary

• PR Add hypershift release-4.22 to pipeline controller lgtm-config #79626 removed the main-only branch filter from the pipeline controller lgtm-config for hypershift so e2e jobs would trigger on all branches (including release branches)
• PR Enroll 23 single-e2e payload repos in pipeline controller LGTM mode #81599 inadvertently re-added the main-only branch filter when bulk-enrolling 23 repos, causing release-4.22 PRs to merge without e2e coverage again (e.g. [release-4.22] OCPBUGS-98627: Skip Azure topology LB scope override for ARO HCP IngressController hypershift#8998)
• Remove the branch filter to match the pattern used by other repos in the config

Test plan

• Verify pipeline controller triggers e2e jobs on release-4.22 PRs when lgtm is applied

🤖 Generated with Claude Code

Summary by CodeRabbit

• Updated the Hypershift pipeline-controller LGTM configuration to remove the main-only branch restriction.
• E2E jobs can now trigger for approved pull requests across all branches, including release branches such as release-4.22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.