MCO: bump golang to 1.13 in 4.5 and above release #8148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4.5 and above releases, Machine-config-operator is switching to kubernetes 1.18.0 version. This requires switching to Go 1.13 Related - openshift/machine-config-operator#1618 Signed-off-by: Sinny Kumari <[email protected]>
openshift-ci-robot
added
the
approved
Contributor
Author
|
/cc @runcom |
Contributor
Author
|
/retest |
Contributor
Author
|
Error log from some of failing tests: |
Member
Is almost certainly fallout from openshift/machine-config-operator#1619 - CI is finally "self hosting" on 4.X and now PRs to the MCO are failing because we need to improve the MCO - new levels of excitement! |
Contributor
Author
hmm, thoughts on how to deal with it? |
Member
The change is being reverted in the CI cluster, so it should just be a matter of waiting a bit and |
Contributor
Author
|
/retest |
Member
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
@sinnykumari: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
@sinnykumari: Updated the following 15 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.5 and above releases, Machine-config-operator is switching to
kubernetes 1.18.0 version. This requires switching to Go 1.13
Related - openshift/machine-config-operator#1618
Signed-off-by: Sinny Kumari [email protected]