Update vendored kubernetes to 1.18.0 #1618
Conversation
openshift-ci-robot
added
the
approved
sinnykumari
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
sinnykumari
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test unit |
In 4.5 and above releases, Machine-config-operator is switching to kubernetes 1.18.0 version. This requires switching to Go 1.13 Related - openshift/machine-config-operator#1618 Signed-off-by: Sinny Kumari <[email protected]>
|
Requires PR openshift/release#8148 for tests to pass |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
Updated all kubernetes related modules according to 1.18 in go.mod file. Then, ran `make go-deps && make update`
With kubernetes 1.18 update, we have also updated other vendored kube modules. Updated client-go module has incompatible APIs which adds context support. More details in https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20200123-client-go-ctx.md In this commit we ran clientgofix tool ( https://github.com/kubernetes-sigs/clientgofix ) in MCO repository to automatically fix API changes $ clientgofix ./... As the tool is in active development, it doesn't fix API at all places. Remaining API changes has been fixed manually as per the API signature. We are making use of context.TODO() to create an empty context wherever required in API call and corresponding empty option object.
apimachinery 1.18 uses errors.Is() function (//github.com/kubernetes/apimachinery/blob/release-1.18/pkg/util/errors/errors.go#L99 ) which has been introduced in Go 1.13. See https://blog.golang.org/go1.13-errors golang release image being used in Dockerfile has been updated to use Go 1.13 version as well
|
@sinnykumari this needs a rebase now that Christian's PR is merged |
|
Rebased and also made changes to fix e2e-gcp-op test failure |
|
/skip |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/cc @yuqi-zhang |
|
nice nice |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
Sorry for the late review, everything looks good!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sinnykumari: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
Ran clientgofix tool ( https://github.com/kubernetes-sigs/clientgofix ) in MCO repository to automatically fix API changes
As the tool is in active development, it doesn't fix API at all places. Remaining API changes has been fixed manually as per the API signature. We are making use of context.TODO() to create an empty context and corresponding empty option object wherever required in API call.