feat(vector): add tls-scanner image to e2e job

[vparfonov]

ref: https://redhat.atlassian.net/browse/LOG-9405

/assign @jcantrill

Summary by CodeRabbit

This change updates the Vector repository’s OpenShift CI e2e job so it now includes the TLS scanner image when running make test-e2e. In practical terms, the Vector release CI configuration is being extended to support TLS scanning as part of the end-to-end test flow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8c2b8a68-8bd0-4dcb-b061-099641a609f3

📥 Commits

Reviewing files that changed from the base of the PR and between 1743681 and f7dabd2.

📒 Files selected for processing (1)

• ci-operator/config/ViaQ/vector/ViaQ-vector-v0.54.0-rh.yaml

---

Walkthrough

Updated a CI configuration file for ViaQ vector v0.54.0-rh to add an IMAGE_TLS_SCANNER environment variable to the cluster-logging-operator-e2e test step command, pointing to a specific TLS scanner image hosted on quay-proxy.ci.openshift.org.

Changes

CI Config Update

Layer / File(s)	Summary
Set IMAGE_TLS_SCANNER for e2e test command ci-operator/config/ViaQ/vector/ViaQ-vector-v0.54.0-rh.yaml	The make test-e2e command now sets IMAGE_TLS_SCANNER to a specific quay-proxy.ci.openshift.org image reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding the tls-scanner image to the Vector e2e job.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes ci-operator YAML to add an env var to e2e commands; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	Only a ci-operator YAML changed; no Ginkgo test code or It blocks were modified, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a CI job command/env var changed in a YAML config; no new Ginkgo tests or MicroShift-unsafe OpenShift APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a ci-operator YAML command changed; no new Ginkgo tests or SNO-sensitive topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only tweaks a ci-operator test command env var; no manifests, replicas, affinity, nodeSelectors, or topology constraints were added.
Ote Binary Stdout Contract	✅ Passed	The PR only edits ci-operator YAML to add IMAGE_TLS_SCANNER; no process-level binary code or stdout writes are introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: PR only updates ci-operator YAML to add IMAGE_TLS_SCANNER to an existing e2e job; no new Ginkgo tests or IPv4/public-internet assumptions were added.
No-Weak-Crypto	✅ Passed	The only change is a CI env var in a YAML job config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons are present.
Container-Privileges	✅ Passed	PR only adds IMAGE_TLS_SCANNER to the e2e command; no privileged/root/host* or allowPrivilegeEscalation settings are present in the touched config.
No-Sensitive-Data-In-Logs	✅ Passed	Diff only adds an IMAGE_TLS_SCANNER pullspec; no secrets, PII, session IDs, or other sensitive data are present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[vparfonov]

/pj-rehearse ack

[openshift-merge-bot]

@vparfonov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[vparfonov]

/pj-rehearse

[openshift-merge-bot]

@vparfonov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[vparfonov]

/assign @xperimental

[xperimental]

The quay-proxy should not be needed inside CI ... I think it would be better to reference the image in the base_images section above and then use the pipeline image. (see here and here)

edit: Also: wouldn't it be better to list IMAGE_TLS_SCANNER along the other environment variables below?

[vparfonov]

see this PR please #79612

[vparfonov]

also not clear why this mapping not working at all: https://github.com/openshift/release/blob/main/core-services/image-mirroring/tls-scanner/mapping_tls_scanner_quay

[xperimental]

I think the same comments would also apply to #79612, which should probably have a follow-up with these changes after this one merges.

re "mapping": I am not talking about image-mirroring out of CI. This job is running inside the CI, which means it should be able to consume the tls-scanner image which is already inside the CI using an item in base_images instead.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@vparfonov: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-ViaQ-vector-v0.54.0-rh-cargo-clippy-check	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-cargo-deny-check-bans	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-cargo-fmt-check	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-clo-functional	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-cluster-logging-operator-e2e	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-images	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-ldd-openssl	ViaQ/vector	presubmit	Ci-operator config changed
pull-ci-ViaQ-vector-v0.54.0-rh-unit	ViaQ/vector	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[vparfonov]

/pj-rehearse

[openshift-merge-bot]

@vparfonov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[vparfonov]

/pj-rehearse pull-ci-ViaQ-vector-v0.54.0-rh-cluster-logging-operator-e2e

[openshift-merge-bot]

@vparfonov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[vparfonov]

/pj-rehearse pull-ci-ViaQ-vector-v0.54.0-rh-cluster-logging-operator-e2e

[openshift-merge-bot]

@vparfonov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xperimental]

/approve
/lgtm
/pj-rehearse ack

[openshift-merge-bot]

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jcantrill]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/ViaQ/vector/OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment