Skip to content

feat(clusterloggingoperator): add tls-scanner image to e2e job. - #79612

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jcantrill:log9405
May 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jcantrill:log9405

Conversation

@jcantrill

@jcantrill jcantrill commented May 21, 2026

Copy link
Copy Markdown
Contributor

ref: https://redhat.atlassian.net/browse/LOG-9405

Summary by CodeRabbit

This PR adds TLS security scanning capability to the end-to-end (e2e) tests for the cluster-logging-operator CI job. Specifically, the change updates the CI configuration for the OpenShift cluster-logging-operator repository to pass the IMAGE_TLS_SCANNER environment variable to the make test-e2e command, pointing to the tls-scanner image (quay-proxy.ci.openshift.org/openshift/ci:tls-scanner_tls-scanner_tls-scanner-tool).

This enables the e2e test suite to perform TLS/SSL certificate scanning and validation as part of the automated testing pipeline, ensuring that the cluster-logging-operator's TLS configurations are properly validated during CI runs.

@jcantrill

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jcantrill: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6397c1aa-9296-4993-b494-3ae4c1b3b195

📥 Commits

Reviewing files that changed from the base of the PR and between 5403786 and 6e8e54d.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/cluster-logging-operator/openshift-cluster-logging-operator-master.yaml

Walkthrough

This PR extends the OpenShift cluster-logging-operator CI configuration by adding a TLS-scanner-enabled e2e test invocation. The e2e-target test step now runs make test-e2e twice: once with standard behavior and once with IMAGE_TLS_SCANNER pointing to the TLS scanner container image.

Changes

E2E TLS Scanner Test

Layer / File(s) Summary
Add TLS scanner test invocation to e2e step
ci-operator/config/openshift/cluster-logging-operator/openshift-cluster-logging-operator-master.yaml
E2E test step configuration adds a second make test-e2e command with IMAGE_TLS_SCANNER environment variable set to the quay-proxy TLS scanner image, extending test coverage to include TLS-scanner-based validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#79416: Both PRs add or enable e2e test runs related to TLS scanning functionality for the cluster-logging-operator.

Suggested labels

jira/valid-reference

Suggested reviewers

  • hongkailiu
  • fao89
  • wking
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a tls-scanner image to the e2e job for the cluster logging operator, which matches the file changes in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo tests found in PR; this is a CI configuration change. The custom check for stable/deterministic Ginkgo test names is not applicable as there are no Ginkgo test definitions to evaluate.
Test Structure And Quality ✅ Passed PR modifies only CI config YAML (openshift-cluster-logging-operator-master.yaml), not Ginkgo test code. Custom check for test structure/quality is not applicable to CI configuration changes.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are CI configuration only (YAML files), not test source code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI configuration YAML files to add IMAGE_TLS_SCANNER parameter. No new Ginkgo test code is added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI/CD configuration files (Prow jobs, ci-operator configs), not deployment manifests, operator code, or controllers, so topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration YAML file, not OTE binary Go test code. The OTE Stdout Contract check applies only to test binaries, not CI config files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR changes are CI configuration only (YAML files), not new Ginkgo e2e tests. No test code additions reviewed since check applies to new test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@jcantrill

Copy link
Copy Markdown
Contributor Author

cc @vparfonov @Clee2691

@jcantrill

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jcantrill: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
@openshift-ci
openshift-ci Bot requested review from Clee2691 and vparfonov May 21, 2026 15:03
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jcantrill: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-logging-operator-master-e2e-target openshift/cluster-logging-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vparfonov

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci

openshift-ci Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3c80883 into openshift:main May 21, 2026
14 of 15 checks passed
@jcantrill
jcantrill deleted the log9405 branch May 21, 2026 15:38
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
srivickynesh pushed a commit to srivickynesh/release that referenced this pull request Aug 5, 2026
malingatembo pushed a commit to malingatembo/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants