Perfscale informing jobs across etcd, kubernetes, cri-o, multus-cni, and mco - #81100
Conversation
WalkthroughThis PR updates perfscale CI job configs across several OpenShift components, broadening skip filters, switching some jobs to always run, and adding new 6-node control-plane perfscale jobs for machine-config-operator and multus-cni. ChangesPerfscale CI job updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml (1)
595-595: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConfirm skipping
manifests//templates/is intended for this perfscale gate.For machine-config-operator,
manifests/andtemplates/can carry functional changes that affect control-plane behavior. Since this is an optional/informing job that's fine, but verify you don't want perfscale signal on those paths.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml` at line 595, The perfscale gate’s skip filter currently excludes `manifests/` and `templates/`, which may hide functional machine-config-operator changes from this job. Review the `skip_if_only_changed` rule in the `machine-config-operator-main` CI config and either keep it only if that behavior is intentional, or narrow/remove those path exclusions so perfscale still runs for changes in `manifests/` and `templates/`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/etcd/openshift-etcd-main.yaml`:
- Around line 93-96: The presubmit job spec for
perfscale-payload-control-plane-6nodes is stale because the generated ProwJob
still has always_run set to false. Regenerate the CI job manifests from the
updated config in openshift-etcd-main.yaml by running make update, and ensure
the generated openshift-etcd-main-presubmits.yaml reflects the always_run: true
change for the
pull-ci-openshift-etcd-main-perfscale-payload-control-plane-6nodes job.
In `@ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml`:
- Around line 501-504: The generated Prow job spec for
perfscale-control-plane-6nodes is out of sync with the source config because the
always_run setting differs between the config and the generated presubmit job.
Regenerate the job definitions by updating the generated
openshift-kubernetes-master-master-presubmits manifest from the source YAML,
ensuring the perfscale-control-plane-6nodes job reflects always_run: true; use
the job name and the generated presubmits file to locate the mismatch.
In `@ci-operator/config/openshift/router/openshift-router-master.yaml`:
- Around line 186-189: The generated Prow job config is out of sync with the
source job definition because perfscale-aws-ingress-perf still has always_run
set incorrectly in the downstream artifact. Regenerate the job definitions by
updating the ci-operator output for openshift-router-master so the generated
presubmits file reflects the source config’s always_run: true value; use the
perfscale-aws-ingress-perf job entry as the reference point and run the repo’s
update generation flow.
---
Nitpick comments:
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml`:
- Line 595: The perfscale gate’s skip filter currently excludes `manifests/` and
`templates/`, which may hide functional machine-config-operator changes from
this job. Review the `skip_if_only_changed` rule in the
`machine-config-operator-main` CI config and either keep it only if that
behavior is intentional, or narrow/remove those path exclusions so perfscale
still runs for changes in `manifests/` and `templates/`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: cbb99848-6c59-4015-855c-c840de08ca80
⛔ Files ignored due to path filters (7)
ci-operator/jobs/openshift/cri-o/openshift-cri-o-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/etcd/openshift-etcd-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/multus-cni/openshift-multus-cni-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/ovn-kubernetes/openshift-ovn-kubernetes-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/router/openshift-router-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (7)
ci-operator/config/openshift/cri-o/openshift-cri-o-main.yamlci-operator/config/openshift/etcd/openshift-etcd-main.yamlci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yamlci-operator/config/openshift/multus-cni/openshift-multus-cni-main.yamlci-operator/config/openshift/ovn-kubernetes/openshift-ovn-kubernetes-main.yamlci-operator/config/openshift/router/openshift-router-master.yaml
fab0d0c to
2654544
Compare
|
@mohit-sheth, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
added
the
needs-rebase
| workflow: openshift-e2e-gcp | ||
| - always_run: false | ||
| as: perfscale-control-plane-6nodes | ||
| - as: perfscale-control-plane-6nodes |
There was a problem hiding this comment.
Applies to all the configs changed in this PR.
There are many env differences and missing workers scale test compared to our mainline payload tests
There was a problem hiding this comment.
updated, everything should look more or less similar now
…omponent repos Add perfscale-control-plane-6nodes as conditional-automatic informing (optional) presubmit to etcd, kubernetes, cri-o, multus-cni, and machine-config-operator. Enable perfscale-aws-ingress-perf as conditional-automatic informing for router. Add skip_if_only_changed to all perfscale presubmits across these repos and ovn-kubernetes to avoid running expensive tests on docs/test-only changes. Uses skip_if_only_changed without always_run: true, following the standard Prow convention where the skip regex implicitly makes the job conditional-automatic. Signed-off-by: Mohit Sheth <msheth@redhat.com>
These directories contain runtime deployment manifests (daemonsets, RBAC, controller configs) and platform-specific MachineConfig templates that directly affect how MCO operates on the cluster. Changes there could impact control-plane performance and should not be skipped. Signed-off-by: Mohit Sheth <msheth@redhat.com>
d0efd52 to
b69bf68
Compare
openshift-ci
Bot
removed
the
needs-rebase
b69bf68 to
d5dc56c
Compare
Update env vars and test steps across cri-o, etcd, kubernetes, mco, and multus-cni to match the mainline payload-control-plane-6nodes config in openshift-eng/ocp-qe-perfscale-ci. Adds workers-scale step, orion consolidated chain, and all CDv2/ND/UDN env vars. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
d5dc56c to
d560520
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse ack |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-cri-o-main-perfscale-control-plane-6nodes |
|
/pj-rehearse pull-ci-openshift-cri-o-main-perfscale-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-etcd-main-perfscale-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mohit-sheth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@mohit-sheth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
3 similar comments
|
@mohit-sheth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@mohit-sheth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@mohit-sheth: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-kubernetes-master-perfscale-control-plane-6nodes pull-ci-openshift-machine-config-operator-main-perfscale-control-plane-6nodes pull-ci-openshift-multus-cni-main-perfscale-control-plane-6nodes pull-ci-openshift-ovn-kubernetes-main-qe-perfscale-payload-control-plane-6nodes pull-ci-openshift-router-master-perfscale-aws-ingress-perf |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mohit-sheth: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
approved
6918b53
into
openshift:main
…and mco (openshift#81100) * Enable perfscale control-plane-6nodes as informing presubmit across component repos Add perfscale-control-plane-6nodes as conditional-automatic informing (optional) presubmit to etcd, kubernetes, cri-o, multus-cni, and machine-config-operator. Enable perfscale-aws-ingress-perf as conditional-automatic informing for router. Add skip_if_only_changed to all perfscale presubmits across these repos and ovn-kubernetes to avoid running expensive tests on docs/test-only changes. Uses skip_if_only_changed without always_run: true, following the standard Prow convention where the skip regex implicitly makes the job conditional-automatic. Signed-off-by: Mohit Sheth <msheth@redhat.com> * Remove manifests/ and templates/ from MCO perfscale skip filter These directories contain runtime deployment manifests (daemonsets, RBAC, controller configs) and platform-specific MachineConfig templates that directly affect how MCO operates on the cluster. Changes there could impact control-plane performance and should not be skipped. Signed-off-by: Mohit Sheth <msheth@redhat.com> * Align perfscale control-plane-6nodes env with 5.0 mainline payload test Update env vars and test steps across cri-o, etcd, kubernetes, mco, and multus-cni to match the mainline payload-control-plane-6nodes config in openshift-eng/ocp-qe-perfscale-ci. Adds workers-scale step, orion consolidated chain, and all CDv2/ND/UDN env vars. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com> --------- Signed-off-by: Mohit Sheth <msheth@redhat.com>
…and mco (openshift#81100) * Enable perfscale control-plane-6nodes as informing presubmit across component repos Add perfscale-control-plane-6nodes as conditional-automatic informing (optional) presubmit to etcd, kubernetes, cri-o, multus-cni, and machine-config-operator. Enable perfscale-aws-ingress-perf as conditional-automatic informing for router. Add skip_if_only_changed to all perfscale presubmits across these repos and ovn-kubernetes to avoid running expensive tests on docs/test-only changes. Uses skip_if_only_changed without always_run: true, following the standard Prow convention where the skip regex implicitly makes the job conditional-automatic. Signed-off-by: Mohit Sheth <msheth@redhat.com> * Remove manifests/ and templates/ from MCO perfscale skip filter These directories contain runtime deployment manifests (daemonsets, RBAC, controller configs) and platform-specific MachineConfig templates that directly affect how MCO operates on the cluster. Changes there could impact control-plane performance and should not be skipped. Signed-off-by: Mohit Sheth <msheth@redhat.com> * Align perfscale control-plane-6nodes env with 5.0 mainline payload test Update env vars and test steps across cri-o, etcd, kubernetes, mco, and multus-cni to match the mainline payload-control-plane-6nodes config in openshift-eng/ocp-qe-perfscale-ci. Adds workers-scale step, orion consolidated chain, and all CDv2/ND/UDN env vars. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com> --------- Signed-off-by: Mohit Sheth <msheth@redhat.com>
4 participants
Enable perfscale control-plane-6nodes as informing presubmit across component repos
Add perfscale-control-plane-6nodes as a conditional-automatic informing presubmit to etcd, kubernetes, cri-o, multus-cni, and machine-config-operator. Enable perfscale-aws-ingress-perf as a conditional-automatic informing presubmit for router.
Add skip_if_only_changed to all perfscale presubmits across these repos and ovn-kubernetes to skip expensive cluster provisioning on docs, test, and metadata-only changes.
Summary by CodeRabbit
This PR expands and tunes perfscale presubmit coverage across several OpenShift component repositories.
Practically, it makes the control-plane 6-node perfscale job an always-run optional presubmit for
etcd,kubernetes,cri-o,multus-cni, andmachine-config-operator, and enables the AWS ingress perf job as an always-run presubmit forrouter. It also addsskip_if_only_changedguards to perfscale jobs in these repos and inovn-kubernetes, so expensive tests are skipped for docs-only, metadata-only, and other low-impact changes.In
machine-config-operatorandmultus-cni, the PR also introduces the newperfscale-control-plane-6nodesjob definition with the expected 6-node AWS perfscale configuration and chained QE test steps.