CNTRLPLANE-3642: ci(hypershift): skip E2E when only unit test files change - #80732
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mgencur: This pull request references CNTRLPLANE-3642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe hypershift main CI config updates ChangesHypershift CI pipeline skip pattern expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mehabhalodiya
left a comment
mehabhalodiya
left a comment
There was a problem hiding this comment.
The Jira acceptance criteria include a make verify target and a tracked directory list to prevent the skip pattern from going stale as new top-level directories are added. Neither appears in this PR. Was this intentionally deferred?
If so, please open a follow-up ticket and link it here, and update the Jira story accordingly. Without the verify target, the risk of silent drift is real — someone adds a new top-level directory of unit tests, forgets to update the skip pattern, and PRs start triggering unnecessary E2E runs again.
|
@mehabhalodiya All of this is done in the sibling PR: openshift/hypershift#8773 |
Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f74d426 to
b9524cf
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/approve |
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mehabhalodiya, mgencur, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@mgencur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
![openshift-prow[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…80732) Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-tevel directories. PRs touching only unit tests outside of test/ no longer trigger expensive E2E runs. More info about matching and non-matching paths in https://regex101.com/r/0RdXcf/1 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 participants
Extend pipeline_skip_if_only_changed to match *_test.go files under all non-test top-level directories. PRs touching only unit tests no longer trigger expensive E2E runs.
This unit test was used to verify the new pattern: mgencur/hypershift@d3de17d
Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3642
Summary by CodeRabbit
This PR modifies the HyperShift CI configuration to optimize E2E (end-to-end) test execution by preventing resource-intensive test runs when PRs contain only unit test changes.
Summary by CodeRabbit
This updates the HyperShift CI configuration to make E2E job skipping smarter for the OpenShift CI setup. In practical terms, changes that only touch unit tests in non-test top-level directories will now be more likely to skip expensive E2E runs, reducing unnecessary CI load for the
openshift/hypershiftrepo.It broadens the
pipeline_skip_if_only_changedmatching logic across several HyperShift jobs to include*_test.gopaths, and also normalizes the markdown path matching used by the GKE v2 job. A unit test was added to verify the new skip pattern behavior.