openshift-logging: Add configuration for Loki 3.7.2 - #80363
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
WalkthroughAdds a ci-operator config for Loki upstream v3.7.2 defining base/build-root images, a single ChangesLoki upstream v3.7.2 CI configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml`:
- Around line 11-22: The CI config references a non-existent Dockerfile for
promtail: in openshift-loki-upstream-v3.7.2.yaml the image entry with "to:
promtail" points at Dockerfile.promtail.ocp which is missing; fix by either
adding Dockerfile.promtail.ocp to the openshift/loki upstream-v3.7.2 branch or
change the dockerfile_path for the promtail image to the correct existing file
(e.g., reuse Dockerfile.ocp or the actual promtail Dockerfile in the repo), and
ensure the image item with "to: promtail" and dockerfile_path are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f962a570-09dd-4b9b-8b5d-ebd451bbc3f5
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
0a79264 to
645ef64
Compare
|
/pj-rehearse auto-ack |
|
@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
JoaoBraveCoding
left a comment
There was a problem hiding this comment.
Aren't we missing an update for the image mirror?
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
|
/pj-rehearse pull-ci-openshift-loki-upstream-v3.7.2-images |
|
@JoaoBraveCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse auto-ack |
|
@JoaoBraveCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
c3140f5
into
openshift:main
|
@xperimental: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @btaani @JoaoBraveCoding
/assign @xperimental
Summary by CodeRabbit
This PR adds CI/operator build configuration for Loki upstream v3.7.2 to the OpenShift release infrastructure. The new configuration file (
openshift-loki-upstream-v3.7.2.yaml) enables automated building, testing, and promotion of Loki 3.7.2 releases through the OpenShift CI pipeline.Key configuration details:
lokicontainer image fromDockerfile.ocpwith ARM64 architecture supportloggingimage namespace with tagv3.7.2make testwith standard resource requests (100m CPU, 200Mi memory per step)This follows the established pattern used for other Loki upstream versions (3.4.3, 3.5.7, 3.6.5) already in the repository, establishing automated CI/CD capabilities for the Loki 3.7.2 release.