Skip to content

openshift-logging: Add configuration for Loki 3.7.2 - #80363

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xperimental:loki-372
Jun 15, 2026
Merged

openshift-logging: Add configuration for Loki 3.7.2#80363
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xperimental:loki-372

Conversation

@xperimental

@xperimental xperimental commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/cc @btaani @JoaoBraveCoding
/assign @xperimental

Summary by CodeRabbit

This PR adds CI/operator build configuration for Loki upstream v3.7.2 to the OpenShift release infrastructure. The new configuration file (openshift-loki-upstream-v3.7.2.yaml) enables automated building, testing, and promotion of Loki 3.7.2 releases through the OpenShift CI pipeline.

Key configuration details:

  • Specifies RHEL9-based builder image and depends on OpenShift 4.22 stable release channel
  • Builds the loki container image from Dockerfile.ocp with ARM64 architecture support
  • Promotes built artifacts to the logging image namespace with tag v3.7.2
  • Defines a test workflow that runs make test with standard resource requests (100m CPU, 200Mi memory per step)

This follows the established pattern used for other Loki upstream versions (3.4.3, 3.5.7, 3.6.5) already in the repository, establishing automated CI/CD capabilities for the Loki 3.7.2 release.

@openshift-ci
openshift-ci Bot requested review from JoaoBraveCoding and btaani June 10, 2026 15:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 49b4b76b-712d-4ab9-8822-a8ecf9fcb5f0

📥 Commits

Reviewing files that changed from the base of the PR and between 87ad54b and 645ef64.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml

Walkthrough

Adds a ci-operator config for Loki upstream v3.7.2 defining base/build-root images, a single loki image build (Dockerfile.ocp, ARM64), a make test workflow, resource requests, promotion to logging:v3.7.2, and zz_generated_metadata.

Changes

Loki upstream v3.7.2 CI configuration

Layer / File(s) Summary
CI build/test/promotion YAML
ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
Adds full ci-operator configuration: base and build-root image selection, single loki image build with Dockerfile.ocp and ARM64 enabled, test job running GOFLAGS=\"\" make test in src, default resource requests (100m CPU, 200Mi), promotion to logging with tag v3.7.2, and zz_generated_metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • JoaoBraveCoding
  • btaani
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'openshift-logging: Add configuration for Loki 3.7.2' directly and accurately describes the main change—adding a CI/operator build configuration for Loki upstream version 3.7.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds only a YAML CI/operator configuration file and does not contain any Ginkgo test code. The custom check for stable/deterministic test names is not applicable here.
Test Structure And Quality ✅ Passed PR adds only YAML CI configuration files, not Ginkgo/Go test code, so test structure check is inapplicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR—only a CI/operator YAML configuration file for Loki 3.7.2. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds CI/operator build configuration YAML file only; no Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only CI/Operator build configuration with no deployment manifests, operator code, or scheduling constraints. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed Check not applicable: PR only adds YAML configuration file, not executable code. OTE Binary Stdout Contract violations can only occur in process-level Go code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only a YAML CI/operator configuration file for Loki 3.7.2, not Ginkgo e2e tests. Check is not applicable to configuration files.
No-Weak-Crypto ✅ Passed PR adds YAML configuration file only; no code, cryptographic implementations, or weak crypto patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) detected.
Container-Privileges ✅ Passed The PR adds a CI/operator build configuration file with no privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation).
No-Sensitive-Data-In-Logs ✅ Passed YAML configuration file contains no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data that could expose sensitive information in logs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml`:
- Around line 11-22: The CI config references a non-existent Dockerfile for
promtail: in openshift-loki-upstream-v3.7.2.yaml the image entry with "to:
promtail" points at Dockerfile.promtail.ocp which is missing; fix by either
adding Dockerfile.promtail.ocp to the openshift/loki upstream-v3.7.2 branch or
change the dockerfile_path for the promtail image to the correct existing file
(e.g., reuse Dockerfile.ocp or the actual promtail Dockerfile in the repo), and
ensure the image item with "to: promtail" and dockerfile_path are consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f962a570-09dd-4b9b-8b5d-ebd451bbc3f5

📥 Commits

Reviewing files that changed from the base of the PR and between 6a2ca63 and 87ad54b.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml

Comment thread ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml Outdated
@xperimental
xperimental force-pushed the loki-372 branch 2 times, most recently from 0a79264 to 645ef64 Compare June 10, 2026 16:12
@xperimental

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 10, 2026

@JoaoBraveCoding JoaoBraveCoding left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we missing an update for the image mirror?

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-loki-upstream-v3.7.2-images openshift/loki presubmit Presubmit changed
pull-ci-openshift-loki-upstream-v3.7.2-test openshift/loki presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@JoaoBraveCoding JoaoBraveCoding left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xperimental

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JoaoBraveCoding

Copy link
Copy Markdown
Contributor

/retest-required

@JoaoBraveCoding

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-openshift-loki-upstream-v3.7.2-images

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@JoaoBraveCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JoaoBraveCoding

Copy link
Copy Markdown
Contributor

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@JoaoBraveCoding: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 15, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit c3140f5 into openshift:main Jun 15, 2026
17 of 18 checks passed
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@xperimental: Updated the following 2 configmaps:

  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_logging_loki_quay using file core-services/image-mirroring/openshift-logging/mapping_logging_loki_quay
  • image-mirror-mappings configmap in namespace ci at cluster core-ci using the following files:
    • key mapping_logging_loki_quay using file core-services/image-mirroring/openshift-logging/mapping_logging_loki_quay
Details

In response to this:

/cc @btaani @JoaoBraveCoding
/assign @xperimental

Summary by CodeRabbit

This PR adds CI/operator build configuration for Loki upstream v3.7.2 to the OpenShift release infrastructure. The new configuration file (openshift-loki-upstream-v3.7.2.yaml) enables automated building, testing, and promotion of Loki 3.7.2 releases through the OpenShift CI pipeline.

Key configuration details:

  • Specifies RHEL9-based builder image and depends on OpenShift 4.22 stable release channel
  • Builds the loki container image from Dockerfile.ocp with ARM64 architecture support
  • Promotes built artifacts to the logging image namespace with tag v3.7.2
  • Defines a test workflow that runs make test with standard resource requests (100m CPU, 200Mi memory per step)

This follows the established pattern used for other Loki upstream versions (3.4.3, 3.5.7, 3.6.5) already in the repository, establishing automated CI/CD capabilities for the Loki 3.7.2 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Jun 15, 2026
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Jun 19, 2026
krisnababu pushed a commit to krisnababu/release that referenced this pull request Jun 29, 2026
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants