Skip to content

openshift-logging: Update loki-operator build to Go 1.26 and OCP 4.22 - #80361

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xperimental:loki-operator-go126
Jun 10, 2026
Merged

openshift-logging: Update loki-operator build to Go 1.26 and OCP 4.22#80361
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
xperimental:loki-operator-go126

Conversation

@xperimental

Copy link
Copy Markdown
Contributor

@openshift-ci
openshift-ci Bot requested review from JoaoBraveCoding and btaani June 10, 2026 15:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-loki-main-build openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-main-ci-index-loki-operator-bundle openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-main-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-main-lint openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-main-test openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-main-test-operator openshift/loki presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@btaani

btaani commented Jun 10, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@btaani: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c55904ee-3276-40f2-b7a7-2e96315cc721

📥 Commits

Reviewing files that changed from the base of the PR and between 6a2ca63 and c72a549.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/loki/openshift-loki-main.yaml

Walkthrough

This PR updates the OpenShift CI configuration for Loki to pin release versions from 4.21 to 4.22 across four configuration sections: base image name, build root golang version (also bumped to 1.26), latest release version, and operator-install test version. No structural or pipeline wiring changes are present.

Changes

Version Pin Updates

Layer / File(s) Summary
CI version pins
ci-operator/config/openshift/loki/openshift-loki-main.yaml
Base image name, build root image stream tag golang version, latest release version, and operator-install test version are updated from 4.21 to 4.22; golang bumped from 1.25 to 1.26.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#77759: Both PRs are version-bump related; the main PR updates Loki release/version pins to 4.22, while PR #77759 fixes multiple release-4.22 CI configs that incorrectly promoted/referenced the 5.0 target instead of 4.22.

Suggested labels

lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: updating loki-operator to use Go 1.26 and target OCP 4.22, which matches the PR's objectives and the version bumps from 4.21 to 4.22 in the configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. All test files use standard Go testing (func TestXxx). Check for Ginkgo test name stability is not applicable.
Test Structure And Quality ✅ Passed PR contains only CI configuration YAML changes (version pin updates), no Ginkgo test code modifications. Check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed This PR only updates CI configuration YAML files (versions and build flags); no new Ginkgo e2e tests are added. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI configuration YAML files (version pins, base images, Go 1.26 compatibility) with no new Ginkgo e2e tests added. Check requires new tests to apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates only CI configuration (ci-operator config YAML) with version bumps from OCP 4.21 to 4.22 and Go 1.26. No deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration files (YAML), not source code. OTE Binary Stdout Contract check applies to source code violations, not infrastructure configuration changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added; PR contains only YAML CI configuration updates for loki-operator version pins and OCP 4.22 targeting.
No-Weak-Crypto ✅ Passed PR modifies only CI configuration YAML file with version pins; contains no cryptographic code, algorithms, or security-sensitive patterns to check.
Container-Privileges ✅ Passed This PR modifies an OpenShift CI configuration file without Kubernetes manifests. No privileged containers, host access, or escalation settings found.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies a CI configuration file that contains no sensitive data exposure (no passwords, tokens, API keys, PII, session IDs, or customer data) in logging or any other context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@btaani

btaani commented Jun 10, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: btaani, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xperimental

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@coderabbitai[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 10, 2026
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit c547a45 into openshift:main Jun 10, 2026
19 checks passed
@xperimental
xperimental deleted the loki-operator-go126 branch June 10, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants