OCM-23813: Migrate cs-rosa-hcp-amd64-upgrade-staging-main OCM FVT job to Prow periodic

[tinaafitz]

Summary by CodeRabbit

This PR updates OpenShift CI configuration in the openshift/release repository by adding a new Prow periodic OCM FVT job for ROSA HCP staging.

What changed and where

• Adds a new test entry ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main to ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml (variant: ocm-fvt-rosa-hcp-staging).

Practical details of the job

• Type & schedule: Prow periodic scheduled daily at 08:00 UTC (cron: "0 8 * * *").
• Execution environment: enabled capability nested-podman and nested_podman: true (runs the rosa-e2e-ocm-fvt test ref inside a nested Podman/container).
• Environment: sets OCM_FVT_JOB_NAME=cs-rosa-hcp-amd64-upgrade-staging-main for the test invocation.

Impact

• Introduces an automated daily OCM functional verification (upgrade) test for ROSA HCP (AMD64) in the staging environment, consistent with other periodic OCM FVT jobs defined in the same file.

[openshift-ci-robot]

@tinaafitz: This pull request references OCM-23813 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5444bb32-01c0-4f19-b350-6d5d06fdef34

📥 Commits

Reviewing files that changed from the base of the PR and between 6df4e4e and 823cba3.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml

---

Walkthrough

Adds a new periodic CI test entry ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main to the rosa-e2e main config, enabled for nested-podman, scheduled at cron: 0 8 * * *, with OCM_FVT_JOB_NAME set to cs-rosa-hcp-amd64-upgrade-staging-main and ref: rosa-e2e-ocm-fvt.

Changes

OCM FVT ROSA HCP Upgrade Staging Test

Layer / File(s)	Summary
Add periodic nested-podman test entry ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml	New tests entry ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main added with capabilities: [nested-podman], cron: 0 8 * * *, environment OCM_FVT_JOB_NAME: cs-rosa-hcp-amd64-upgrade-staging-main, and ref: rosa-e2e-ocm-fvt.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• openshift/release#78591: Adds a similar scheduled OCM FVT periodic job for cs-rosa-hcp-upgrade-staging-main using nested-podman.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

• bmeng
• dustman9000

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	rosa-e2e-ocm-fvt-commands.sh sources credential files (ocm-tokens, jira-cred) and exports all env vars via env command to podman, exposing authentication tokens that may be logged by testing tools.	Explicitly whitelist only required env vars instead of exporting all env vars with 'env | grep'. Filter credentials before passing to container.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: migrating a specific OCM FVT job to a Prow periodic job. It references the ticket (OCM-23813), identifies the specific job being migrated, and explains the action taken, which directly matches the changeset content.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies CI configuration files only (YAML), not Ginkgo test files. Check for stable/deterministic test names is not applicable to CI job configurations.
Test Structure And Quality	✅ Passed	PR modifies CI/CD configuration YAML only; no Ginkgo test code present. Custom check for test structure is not applicable to CI workflow configuration files.
Microshift Test Compatibility	✅ Passed	PR adds CI configuration to run external OCM FVT tests, not new Ginkgo e2e tests. No test code files are added; check doesn't apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds only CI job configuration YAML, not Ginkgo e2e tests. Check applies when new tests with code (It(), Describe(), etc.) are added; this PR modifies CI configuration only.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only CI-operator test configuration for the openshift-release repository, not deployment manifests, operator code, or controllers. No topology-aware scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML configuration files (not Go code). OTE Binary Stdout Contract check is inapplicable to CI configuration changes without source code modifications.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds CI job configuration entry, not Ginkgo e2e tests. Check applies only to new Ginkgo test code (It/Describe/Context/When). No Go test files modified.
No-Weak-Crypto	✅ Passed	No weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) implementations or custom crypto found in PR; changes are CI configuration and documentation only.
Container-Privileges	✅ Passed	File contains no privileged mode, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or root configurations. nested-podman capability is legitimate CI testing infrastructure.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tinaafitz]

/pj-rehearse ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@tinaafitz: job(s): ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main either don't exist or were not found to be affected, and cannot be rehearsed

[tinaafitz]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tinaafitz]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tinaafitz]

/retest

[tinaafitz]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[dustman9000]

/lgtm

[dustman9000]

/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[dustman9000]

/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tinaafitz]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tinaafitz]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main

[openshift-merge-bot]

@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@tinaafitz: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-rosa-hcp-amd64-upgrade-staging-main	N/A	periodic	Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-rosa-hcp-pl-staging-main	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[dustman9000]

/lgtm
/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, tinaafitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-online/rosa-e2e/OWNERS [dustman9000]
• ci-operator/jobs/openshift-online/rosa-e2e/OWNERS [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tinaafitz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.