OCM-23812: Migrate cs-rosa-hcp-upgrade-staging-main OCM FVT job to Prow periodic - #78591
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tinaafitz: This pull request references OCM-23812 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdded a new scheduled CI test job ChangesPeriodic CS Rosa HCP Upgrade Job
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml (1)
111-112: Prefer an immutableocmciimage reference for reproducible periodic runs.Using
:lateston Line 111 makes job behavior drift over time. Pin to a versioned tag or digest to stabilize debugging and rollback.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml` around lines 111 - 112, The job uses a floating image tag "quay.io/redhat-services-prod/ocmci/ocmci:latest" which can drift; replace this with an immutable, versioned tag or digest (for example a specific semver tag or sha256 digest) so the periodic run is reproducible—update the image reference in the job invocation that runs "ocmtest test --service cms --job cs-rosa-hcp-upgrade-staging-main --reportJiraTicket" to point at the chosen pinned tag/digest.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 89-104: The heredoc that generates /tmp/podman.env using "env -i
bash --norc --noprofile << 'EOF' ... EOF" can mask failures of the two source
commands (source /usr/local/cs-qe-credentials/ocm-tokens and source
/usr/local/cs-qe-credentials/jira-cred); modify the heredoc to enable fail-fast
by adding a strict shell header (set -euo pipefail) at its start or by appending
explicit checks after each source (e.g., source ... || { echo "failed to source
ocm-tokens"; exit 1; }) so that any sourcing error causes the heredoc to exit
non‑zero and prevent writing an incomplete /tmp/podman.env; apply the same
change to the duplicate heredoc used in the
ocm-fvt-periodic-cs-rosa-hcp-ad-staging-main job.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 111-112: The job uses a floating image tag
"quay.io/redhat-services-prod/ocmci/ocmci:latest" which can drift; replace this
with an immutable, versioned tag or digest (for example a specific semver tag or
sha256 digest) so the periodic run is reproducible—update the image reference in
the job invocation that runs "ocmtest test --service cms --job
cs-rosa-hcp-upgrade-staging-main --reportJiraTicket" to point at the chosen
pinned tag/digest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a901a003-3166-444d-915d-5cc9f8f528fa
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml
tinaafitz
changed the title
|
/pj-rehearse ocm-fvt-periodic-cs-rosa-hcp-upgrade-staging-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tinaafitz: job(s): ocm-fvt-periodic-cs-rosa-hcp-upgrade-staging-main either don't exist or were not found to be affected, and cannot be rehearsed |
5b0409b to
1cb3776
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-upgrade-staging-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/lgtm |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
openshift-ci
Bot
added
lgtm
1cb3776 to
fc62c7d
Compare
openshift-ci
Bot
removed
needs-rebase
|
@tinaafitz, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
/lgtm |
|
/test ordered-prow-config |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/retest-required |
|
/hold Revision 0b9d3b3 was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
0b9d3b3 to
d83bedf
Compare
|
/lgtm |
openshift-ci
Bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, tinaafitz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cf20118
into
openshift:main
3 participants
Migrate cs-rosa-hcp-upgrade-staging-main OCM FVT job to Prow periodic
This PR adds a new periodic Prow CI job to the OpenShift release repository's CI definitions for OpenShift Online Rosa E2E tests. The change lives in ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml and introduces the ocm-fvt-periodic-cs-rosa-hcp-upgrade-staging-main job.
Practical impact:
Scope: CI configuration for OpenShift Online Rosa E2E within the openshift/release repo — adds a scheduled periodic job to run the existing OCM FVT test in a Prow periodic context.