Skip to content

TRT-2595: Revert "Default vSphere VCM leases to multi-tenant (#76852)" - #76962

Closed
stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:revert-pr-76852
Closed

stbenjam wants to merge 1 commit into
openshift:mainfrom
stbenjam:revert-pr-76852

Conversation

@stbenjam

@stbenjam stbenjam commented Mar 27, 2026

Copy link
Copy Markdown
Member

Summary

This reverts commit e3ee0ee (PR #76852).

The change to default vSphere VCM leases to multi-tenant broke all vSphere UPI jobs, which require single-tenant leases for sufficient IP addresses. The upi-conf-vsphere-vcm step fails immediately with:

SUBNETS.JSON does not contain enough addresses. This workflow is expected to be a single-tenant lease.

This has been blocking install-analysis-all for 2 consecutive payloads:

  • 4.22.0-0.nightly-2026-03-26-231124 (Rejected)
  • 4.22.0-0.nightly-2026-03-26-163214 (Rejected)

Jira

Fixes: TRT-2595

See Also

/cc @jcpowermac

…ft#76852)"

This reverts commit e3ee0ee.

The change to default vSphere VCM leases to multi-tenant broke all
vSphere UPI jobs, which require single-tenant leases for sufficient
IP addresses. The upi-conf-vsphere-vcm step fails immediately with
"SUBNETS.JSON does not contain enough addresses."

This has been blocking install-analysis-all for 2 consecutive payloads.

Fixes: https://issues.redhat.com/browse/TRT-2595

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested a review from jcpowermac March 27, 2026 09:20
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@stbenjam: This pull request references TRT-2595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This reverts commit e3ee0ee (PR #76852).

The change to default vSphere VCM leases to multi-tenant broke all vSphere UPI jobs, which require single-tenant leases for sufficient IP addresses. The upi-conf-vsphere-vcm step fails immediately with:

SUBNETS.JSON does not contain enough addresses. This workflow is expected to be a single-tenant lease.

This has been blocking install-analysis-all for 2 consecutive payloads:

  • 4.22.0-0.nightly-2026-03-26-231124 (Rejected)
  • 4.22.0-0.nightly-2026-03-26-163214 (Rejected)

Jira

Fixes: TRT-2595

See Also

/cc @jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-upi

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stbenjam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-master-edge-e2e-vsphere-assisted-4-22 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.45-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.47-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.50-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.51-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.46-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-assisted-version-placeholder-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.43-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.48-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.49-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-v2.42-e2e-vsphere-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-master-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-5.0-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.23-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.22-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.21-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.20-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.19-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.18-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.17-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.16-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.15-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.14-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.13-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.12-e2e-vsphere openshift/vmware-vsphere-csi-driver presubmit Registry content changed

A total of 3283 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam

Copy link
Copy Markdown
Member Author

Took the fix instead, #76960

@stbenjam stbenjam closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants