Default vSphere VCM leases to multi-tenant - #76852
Merged
openshift-merge-bot[bot] merged 1 commit intoMar 26, 2026
Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-merge-bot[bot] merged 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci
Bot
added
the
approved
Contributor
|
/lgtm |
Contributor
Author
|
/pj-rehearse help |
Contributor
|
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@jcpowermac: job(s): help either don't exist or were not found to be affected, and cannot be rehearsed |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn |
Contributor
|
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@jcpowermac: job(s): periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn, periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn either don't exist or were not found to be affected, and cannot be rehearsed |
Contributor
Author
|
/close |
Contributor
|
@jcpowermac: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/reopen |
Contributor
|
@jcpowermac: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn |
Contributor
|
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@jcpowermac: job(s): periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn, periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn either don't exist or were not found to be affected, and cannot be rehearsed |
Contributor
Author
|
/close |
Contributor
|
@jcpowermac: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/reopen |
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
Contributor
|
@jcpowermac: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jcpowermac
force-pushed
the
all-vsphere-jobs-multi-except
branch
from
March 26, 2026 11:24
4a97aa7 to
47ad8fb
Compare
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Mar 26, 2026
e3ee0ee
into
openshift:main
10 of 12 checks passed
stbenjam
added a commit
to stbenjam/release
that referenced
this pull request
Mar 27, 2026
…ange openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stbenjam
added a commit
to stbenjam/release
that referenced
this pull request
Mar 27, 2026
…ft#76852)" This reverts commit e3ee0ee. The change to default vSphere VCM leases to multi-tenant broke all vSphere UPI jobs, which require single-tenant leases for sufficient IP addresses. The upi-conf-vsphere-vcm step fails immediately with "SUBNETS.JSON does not contain enough addresses." This has been blocking install-analysis-all for 2 consecutive payloads. Fixes: https://issues.redhat.com/browse/TRT-2595 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…ange (#76960) #76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
memodi
pushed a commit
to memodi/release
that referenced
this pull request
Mar 27, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
mgencur
pushed a commit
to mgencur/release
that referenced
this pull request
Mar 30, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
mgencur
pushed a commit
to mgencur/release
that referenced
this pull request
Mar 30, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
eliorerz
pushed a commit
to eliorerz/release
that referenced
this pull request
Jun 3, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
eliorerz
pushed a commit
to eliorerz/release
that referenced
this pull request
Jun 3, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
fjglira
pushed a commit
to fjglira/release
that referenced
this pull request
Jun 3, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
fjglira
pushed a commit
to fjglira/release
that referenced
this pull request
Jun 3, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
andrej1991
pushed a commit
to andrej1991/release
that referenced
this pull request
Jul 6, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
andrej1991
pushed a commit
to andrej1991/release
that referenced
this pull request
Jul 6, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
SachinNinganure
pushed a commit
to SachinNinganure/release
that referenced
this pull request
Jul 20, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
SachinNinganure
pushed a commit
to SachinNinganure/release
that referenced
this pull request
Jul 20, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
malingatembo
pushed a commit
to malingatembo/release
that referenced
this pull request
Aug 5, 2026
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides. Made-with: Cursor
malingatembo
pushed a commit
to malingatembo/release
that referenced
this pull request
Aug 5, 2026
…ange (openshift#76960) openshift#76852 changed the default VCM network type to multi-tenant, but vSphere UPI workflows require single-tenant leases for sufficient IP addresses. This sets DEFAULT_NETWORK_TYPE to single-tenant in all 5 UPI chain definitions and fixes an undefined variable bug (SUBNETS_CONFIG -> NETWORK_CONFIG) in the error handler. Fixes: TRT-2595 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
not-stbenjam
added a commit
to stbenjam/ai-helpers
that referenced
this pull request
Aug 21, 2026
A revert is a revert. Drop the separate expected_ci_config_issues bucket — an openshift/release CI-config culprit is just another revert candidate and belongs in expected_candidates like any other. The split meant no judge actually required finding those reverts: both expected_candidates_found and revert_scoring_accuracy read only expected_candidates, so a model could miss a real revert (e.g. case-001's openshift/release#76852) and still score 5. - case-001: move openshift/release#76852 into expected_candidates (now two expected reverts: cluster-authentication-operator#839 and release#76852). - no_unexpected_reverts: allow-list from expected_candidates only. - revert_scoring_accuracy: score against every expected candidate. Score 5 requires all expected reverts found at >= 85 with correct linkage; a missed revert is a wrong result (2 or 1). - Remove the expected_ci_config_issues field from the dataset schema docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
not-stbenjam
added a commit
to stbenjam/ai-helpers
that referenced
this pull request
Aug 21, 2026
openshift/release#76852 lived in a separate expected_ci_config_issues bucket that no judge required, so a run could miss that revert and still score full marks on case-001. Fold it into expected_candidates and drop the special bucket so every revert is required uniformly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
stbenjam
pushed a commit
to openshift-eng/ai-helpers
that referenced
this pull request
Aug 21, 2026
) * fix(ci): treat CI-config PRs as ordinary revert candidates openshift/release#76852 lived in a separate expected_ci_config_issues bucket that no judge required, so a run could miss that revert and still score full marks on case-001. Fold it into expected_candidates and drop the special bucket so every revert is required uniformly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(ci): make revert_scoring_accuracy result-first, not proximity-based Replace the confidence-proximity scale (which docked a correct verdict for scoring above expected_confidence) with a threshold-based 5-to-1 scale: full credit when every expected candidate is scored >= 85 and linked, or no revert when none is expected. expected_confidence becomes a reference floor rather than a target. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(ci): drop unused expected_confidence from revert scoring The revert_scoring_accuracy rubric is threshold-based (a candidate at or above 85 is correct), which conflicted with the expected_confidence reference-floor text and made the field redundant — no judge reads it. Remove the calibration paragraph and the expected_confidence field from all payload-analysis cases and the schema note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(ci): drop redundant min_confidence; use the 85 revert threshold Every expected_candidate is now a revert, so each min_confidence was just the revert threshold copied per candidate. Hardcode the 85 threshold in expected_candidates_found and remove the field from all payload-analysis cases and the schema note. Also drop case-006's below-threshold "secondary candidate" (#8138) so expected_candidates holds only actual reverts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(ci): clarify the 85 revert threshold in revert_scoring_accuracy State the asymmetry plainly so the judge can't read a low-confidence extra candidate as a false revert: >= 85 is a proposed revert, below 85 is an ignored maybe. Expected reverts must reach 85; an extra candidate is a false revert only at 85 or above. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(ci): bump ci plugin to 0.0.90; drop N/A component from case-001 Bump the ci plugin version and sync marketplace/docs to satisfy the check-version-bump gate. Also drop the non-applicable component field from the openshift/release revert candidate in case-001 (component is documentation only and not consumed by any judge). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a JOB_NAME_SAFE exception list for single-tenant requests so most jobs use the shared default while preserving explicit overrides.
Made-with: Cursor