Skip to content

Installer vSphere UPI: terraform destroy the bootstrap module #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 25, 2020
Merged

Installer vSphere UPI: terraform destroy the bootstrap module #7618

openshift-merge-robot merged 1 commit into from
Mar 25, 2020

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Mar 12, 2020 •
edited
Loading

The current approach of scaling down the bootstrap module's instance_count to 0 by
applying a variable causes problems with Terraform 0.12.x.
Explicitly destroying the bootstrap module after bootstrap has
completed should have the same effect.

/cc @jcpowermac

Blocks: openshift/installer#3235

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2020
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 12, 2020

/test pj-rehearse

@LorbusChris
Installer vSphere UPI: terraform destroy the bootstrap module
df6b06f 
The current approach of scaling down the instance_count to 0 by
applying a variable causes problems with Terraform 0.12.x.
Explicitly destroying the bootstrap module after bootstrap has
completed should have the same effect.
@LorbusChris LorbusChris force-pushed the vsphere-bootstrap-destroy branch from d2fd054 to df6b06f Compare March 12, 2020 22:52
@LorbusChris LorbusChris changed the title installer-upi: vSphere: Use terraform destroy for bootstrap modules Installer vSphere UPI: terraform destroy the bootstrap module Mar 12, 2020
@LorbusChris LorbusChris mentioned this pull request Mar 13, 2020
Closed
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 13, 2020

/retest

1 similar comment
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 13, 2020

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 13, 2020

@jcpowermac ptal :)
the PR seems to be doing what it's supposed to do, but tests fail for seemingly unrelated reasons.

@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 13, 2020

@LorbusChris going to test this locally with 4.4 to see if it will work there.

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 23, 2020

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 23, 2020

wondering whether this works:
/test ci/rehearse/openshift/installer/master/e2e-vsphere

@sdodson
Copy link
Member

sdodson commented Mar 25, 2020

/lgtm
/approve
Reviewed rehearsal jobs, e2e failures aside, all jobs clearly destroy bootstrap resources.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2020
@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 25, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, LorbusChris, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Mar 25, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a421b78 into openshift:master Mar 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

@LorbusChris: Updated the following 10 configmaps:

  • prow-job-cluster-launch-installer-upi-src configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-upi-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
  • prow-job-cluster-launch-installer-upi-src configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-upi-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-src configmap in namespace ci at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
  • prow-job-cluster-launch-installer-upi-src configmap in namespace ci-stg at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
  • prow-job-cluster-launch-installer-upi-src configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-upi-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
Details

In response to this:

The current approach of scaling down the bootstrap module's instance_count to 0 by
applying a variable causes problems with Terraform 0.12.x.
Explicitly destroying the bootstrap module after bootstrap has
completed should have the same effect.

/cc @jcpowermac

Blocks: openshift/installer#3235

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-azure-upi df6b06f link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere df6b06f link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere-operator df6b06f link /test pj-rehearse
ci/prow/pj-rehearse df6b06f link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@sdodson sdodson

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LorbusChris @jcpowermac @sdodson @openshift-ci-robot @openshift-bot @openshift-merge-robot