Skip to content

UPI: Update Terraform to v0.12.21 #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LorbusChris wants to merge 2 commits into from
Closed

UPI: Update Terraform to v0.12.21 #3235

LorbusChris wants to merge 2 commits into from

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Mar 4, 2020 •
edited
Loading

fcos branch equiv in #3222

/cc @abhinavdahiya

Blocked on: openshift/release#7618

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 4, 2020
@LorbusChris LorbusChris mentioned this pull request Mar 4, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Mar 4, 2020

/test e2e-metal

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 4, 2020

/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 4, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 4, 2020

/test e2e-metal
/test e2e-vsphere

abhinavdahiya
abhinavdahiya reviewed Mar 4, 2020
View reviewed changes
@LorbusChris LorbusChris force-pushed the upi-tf-0.12.x branch 2 times, most recently from dc484af to 766d4a0 Compare March 4, 2020 23:33
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 4, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris LorbusChris changed the title UPI: Update Terraform to v0.12.21 WIP: UPI: Update Terraform to v0.12.21 Mar 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2020
@LorbusChris LorbusChris force-pushed the upi-tf-0.12.x branch 2 times, most recently from 8155db8 to 78f6b75 Compare March 5, 2020 03:26
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/refresh

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 5, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 25, 2020

/test e2e-metal
/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 25, 2020

/test e2e-vsphere

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Mar 25, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 25, 2020

hmm weird, vsphere-upi again failed with

Apply complete! Resources: 31 added, 0 changed, 0 destroyed.
No instance found for the given address!

openshift/release#7618 was supposed to fix this. Are are already picking up the new CI job config?

retesting...
/test e2e-metal
/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 26, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

meh...
/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/test e2e-vsphere-upi

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Mar 27, 2020

/retest
/test e2e-vsphere-upi

@jcpowermac
Copy link
Contributor

jcpowermac commented Apr 9, 2020

@LorbusChris can you pull out the vsphere changes?
I have this PR to fixup vsphere:
#3429

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Apr 9, 2020

@jcpowermac I've removed the 3rd commit. Lmk if you need me to change up the content of the first one, or remove it entirely. You could also cherry-pick the second commit onto your PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 9, 2020

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-upi 9fa1211315ff3643f53f52a2208e4efe4096024b link /test e2e-vsphere-upi
ci/prow/e2e-vsphere 9fa1211315ff3643f53f52a2208e4efe4096024b link /test e2e-vsphere
ci/prow/e2e-libvirt 4d69ccc link /test e2e-libvirt
ci/prow/e2e-openstack 4d69ccc link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 4d69ccc link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DanyC97 DanyC97 mentioned this pull request Apr 13, 2020
Closed
@LorbusChris LorbusChris mentioned this pull request Apr 13, 2020
Merged
@jcpowermac
Copy link
Contributor

jcpowermac commented Apr 16, 2020

Cherry picked the commit from this PR and rebased for main.tf changes
#3429
closing

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

@jcpowermac: Closed this PR.

Details

In response to this:

Cherry picked the commit from this PR and rebased for main.tf changes
#3429
closing

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LorbusChris @openshift-ci-robot @sdodson @vrutkovs @abhinavdahiya @jcpowermac