-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add a baremetal-runtimecfg-ubi8 image #7537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3667ff0 to
1a51ad0
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
4.5 would have golang-based binaries instead of python scripts, but cherrypicking the change to 4.4 for OKD may be too intrusive, so that lgtm |
|
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Superseded by openshift/machine-config-operator#1564 which obsoletes containerization of the Python scripts |
|
@LorbusChris: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In OKD-on-FCOS there is no Python on the host, however on Baremetal, OpenStack, oVirt and vSphere some python scripts are laid out on the host via MCO to find and setup IPs. A way to solve this problem is to containerize them.
The scripts have already been added to the baremetal-runtimecfg repo and are included in containers built from that location (openshift/baremetal-runtimecfg#46).
However, as some of the scripts are written in Python 3, the current UBI7-based containers (which only contain Python 2) cannot be used for running them.
This PR adds a baremetal-runtimecfg-ubi8 image that is intended to be used for running the scripts on FCOS in a containerized fashion. (UBI8 is not currently an option for OCP as support for RHEL7 as worker nodes has to be retained.)
/cc @vrutkovs