Skip to content

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Mar 9, 2020

In OKD-on-FCOS there is no Python on the host, however on Baremetal, OpenStack, oVirt and vSphere some python scripts are laid out on the host via MCO to find and setup IPs. A way to solve this problem is to containerize them.

The scripts have already been added to the baremetal-runtimecfg repo and are included in containers built from that location (openshift/baremetal-runtimecfg#46).

However, as some of the scripts are written in Python 3, the current UBI7-based containers (which only contain Python 2) cannot be used for running them.

This PR adds a baremetal-runtimecfg-ubi8 image that is intended to be used for running the scripts on FCOS in a containerized fashion. (UBI8 is not currently an option for OCP as support for RHEL7 as worker nodes has to be retained.)

/cc @vrutkovs

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LorbusChris
To complete the pull request process, please assign celebdor, smarterclayton
You can assign the PR to them by writing /assign @celebdor @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2020
@vrutkovs
Copy link
Contributor

vrutkovs commented Mar 9, 2020

/cc @celebdor @smarterclayton

4.5 would have golang-based binaries instead of python scripts, but cherrypicking the change to 4.4 for OKD may be too intrusive, so that lgtm

@LorbusChris
Copy link
Contributor Author

@vrutkovs and @celebdor where is the Python to Golang translation being tracked? Has that been completed already?

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/baremetal-runtimecfg/release-4.6/images 1a51ad0 link /test pj-rehearse
ci/rehearse/openshift/baremetal-runtimecfg/release-4.6/images-build01 1a51ad0 link /test pj-rehearse
ci/prow/pj-rehearse 1a51ad0 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Contributor Author

Superseded by openshift/machine-config-operator#1564 which obsoletes containerization of the Python scripts
/close

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: Closed this PR.

Details

In response to this:

Superseded by openshift/machine-config-operator#1564 which obsoletes containerization of the Python scripts
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants