Add non-virtual-ip script #46
Conversation
openshift-ci-robot
added
the
size/L
|
/assign celebdor |
vrutkovs
force-pushed
the
non-virtual-ip-script
branch
from
96a81e6 to
d73a337
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1516/ |
|
This script is not yet being used anywhere, so its safe to merge |
|
Tested this on OKD - workers join the cluster as expected. /cc @celebdor PTAL. |
|
This script was recently modified by commits openshift/machine-config-operator@cdd53fc and openshift/machine-config-operator@d93d1e9. As of yesterday with openshift/machine-config-operator#1483, OpenStack also uses this newer |
vrutkovs
force-pushed
the
non-virtual-ip-script
branch
from
d73a337 to
62589c5
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1526/ |
|
/retest |
|
/lgtm The scripts now functionally match the BM and OpenStack ones in master MCO. There are some whitespace diffs that will make pep8 complain, but I do not think we care here, do we? |
|
/retest |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1527/ |
|
/retest Prow issues |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, mandre, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.4 |
|
@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: new pull request created: #48 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
MCO is placing a script on every node to setup non-virtual-ip via NM (see https://github.com/openshift/machine-config-operator/blob/fcos/templates/worker/00-worker/openstack/files/openstack-non-virtual-ip.yaml)
This script runs on host and requires Python on host. Instead this script should be in
baremetalcfg-runtimecontainer. MCO should use a podman wrapper with--net=hostto run it in container, as some hosts (e.g. Fedora CoreOS) may not have python installed.Eventually this script should be rewritten in golang.
Reference: openshift/machine-config-operator#1430