Skip to content

Conversation

@steveej
Copy link
Contributor

@steveej steveej commented Feb 28, 2020

It's unclear to me why the prefix had been there before the previous
change, but it seems like it's incorrect as it is.

/cc @vrutkovs

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2020
@vrutkovs
Copy link
Contributor

/approve
/cc @hongkailiu @petr-muller @bbguimaraes @droslean

@vrutkovs
Copy link
Contributor

Required to fix cargo-test in cincinnati and #7370

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
It's unclear to me why the prefix had been there before the previous
change, but it seems like it's incorrect as it is.
@steveej steveej force-pushed the pr/cincinnati-secret-map-fix branch from 015ba1b to af8aa2b Compare February 28, 2020 14:21
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@vrutkovs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, steveeJ, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit ea77c37 into openshift:master Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@steveej: Updated the following 2 configmaps:

  • secret-mirroring configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key mapping.yaml using file core-services/secret-mirroring/_mapping.yaml
  • secret-mirroring configmap in namespace ci at cluster default using the following files:
    • key mapping.yaml using file core-services/secret-mirroring/_mapping.yaml
Details

In response to this:

It's unclear to me why the prefix had been there before the previous
change, but it seems like it's incorrect as it is.

/cc @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steveej steveej deleted the pr/cincinnati-secret-map-fix branch February 28, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants